From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Aaron Lauterer <a.lauterer@proxmox.com>
Subject: [pve-devel] applied: Re: [PATCH v2 manager] ui: utils: monitor_ceph_installed: avoid setting nodename to localhost
Date: Sat, 22 Apr 2023 09:50:55 +0200 [thread overview]
Message-ID: <851f4896-176d-3f4b-48a8-d2f1d28b76f0@proxmox.com> (raw)
In-Reply-To: <20230420123141.1465161-1-a.lauterer@proxmox.com>
On 20/04/2023 14:31, Aaron Lauterer wrote:
> If a user is accessing the Ceph panel via Datacenter -> Ceph, then the
> install & config wizard might be shown. The nodename that is passed to
> the wizard will decide the ID of the initial MON and MGR services.
>
> Therefore, don't fall back to 'localhost' but the actual name of the
> node to which we are connected to. The result will be that the first MON
> and MGR will have the expected ID instead of 'localhost'.
>
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
>
> changes since ui: CephInstallWizard: avoid using localhost on first configuration:
>
> * set the node name in the utils function that calls the wizard and not
> within the wizard.
>
> www/manager6/Utils.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
prev parent reply other threads:[~2023-04-22 7:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 12:31 [pve-devel] " Aaron Lauterer
2023-04-22 7:50 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=851f4896-176d-3f4b-48a8-d2f1d28b76f0@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox