From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Aaron Lauterer <a.lauterer@proxmox.com>
Subject: [pve-devel] applied: [PATCH] pve7to8: ceph version check: ignore commit hash
Date: Mon, 5 Jun 2023 19:21:45 +0200 [thread overview]
Message-ID: <850780db-fe46-7ea4-a247-79ad3eaf2f9a@proxmox.com> (raw)
In-Reply-To: <20230602160402.164448-1-a.lauterer@proxmox.com>
Am 02/06/2023 um 18:04 schrieb Aaron Lauterer:
> The commit hash of the Ceph version might be different between major
> releases. For example:
> ceph version 17.2.6 (810db68029296377607028a6c6da1ec06f5a2b27) quincy (stable)
> ceph version 17.2.6 (995dec2cdae920da21db2d455e55efbc339bde24) quincy (stable)
>
> This can lead to unnecessary warnings of multiple detected versions.
> Therefore, extract the version, e.g. 'ceph version 17.2.6', and the
> commit hash. Use the simplified version for the version checks and show
> an info line when the commit is different instead of a warning.
> If the commit hashes are the only difference, we are likely in the
> middle of the upgrade.
>
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> PVE/CLI/pve7to8.pm | 25 +++++++++++++++++++++++--
> 1 file changed, 23 insertions(+), 2 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2023-06-05 17:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 16:04 [pve-devel] " Aaron Lauterer
2023-06-05 17:21 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=850780db-fe46-7ea4-a247-79ad3eaf2f9a@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox