From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE user list <pve-user@lists.proxmox.com>,
Jan Vlach <janus@volny.cz>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PVE-User] Proxmox VE 8.1 released!
Date: Fri, 24 Nov 2023 08:27:52 +0100 (CET) [thread overview]
Message-ID: <850679507.1460.1700810872653@webmail.proxmox.com> (raw)
In-Reply-To: <969ADBB0-ACE4-4136-AAB5-DC02802A4CA8@volny.cz>
> Jan Vlach <janus@volny.cz> hat am 23.11.2023 23:35 CET geschrieben:
>
>
> Hello Martin,
>
> I'm sorry for stupid question, but I don't quite follow what the OpenZFS 2.2.0 with "the most important bugfixes from 2.2.1" means.
>
> there is issue 15526 (https://github.com/openzfs/zfs/issues/15526 <https://github.com/openzfs/zfs/issues/15526>) in openzfs that enables block cloning feature by default and that on linux "eats" data.
>
> OpenZFS 2.2.1 specifically switches the block cloning on by default to off by default and nothing else. ( https://github.com/openzfs/zfs/commit/479dca51c66a731e637bd2d4f9bba01a05f9ac9f <https://github.com/openzfs/zfs/commit/479dca51c66a731e637bd2d4f9bba01a05f9ac9f> )
>
> So is the code at 2.2.0 (toxic) eating data by default or at 2.2.1 where block cloning is disabled by default and therefore safe?
>
> Thank you for clarification,
> JV
we cherry-picked the relevant patches from 2.2.1, but it seems there is now new information that block cloning just made the bug easier to trigger but was not actually the cause. we'll include any follow-up fixes promptly after testing, as usual.
https://git.proxmox.com/?p=zfsonlinux.git;a=commit;h=96c807af63f70dc930328e5801659a5bd40e6d47
prev parent reply other threads:[~2023-11-24 7:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 14:27 [pve-devel] " Martin Maurer
[not found] ` <969ADBB0-ACE4-4136-AAB5-DC02802A4CA8@volny.cz>
2023-11-24 7:27 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=850679507.1460.1700810872653@webmail.proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=janus@volny.cz \
--cc=pve-devel@lists.proxmox.com \
--cc=pve-user@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox