From: Dominik Csapak <d.csapak@proxmox.com>
To: Fabian Ebner <f.ebner@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH manager v2 2/3] fix #4053: don't run vzdump jobs when they change from disabled->enabled
Date: Wed, 13 Jul 2022 13:13:31 +0200 [thread overview]
Message-ID: <84e77301-12bd-3a3a-07d9-b22487e9018d@proxmox.com> (raw)
In-Reply-To: <7361eb4f-e413-f428-df69-3d5ba347b2b2@proxmox.com>
On 7/13/22 13:10, Fabian Ebner wrote:
> Am 02.06.22 um 09:42 schrieb Dominik Csapak:
>> by updating the timestamp in the job state when enabled is changing
>> from 0 -> 1. We do it this way too in PBS for example, and is the more
>> sensible behaviour.
>>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>
> We've got a problem here. The state file is per-node, but a job can be
> for all nodes. When going from disabled to enabled, the job will still
> be executed on all nodes except the one that did the job config update.
> Even when a job is for a single node, the job update can happen from a
> different node.
>
> Issue reported in the community forum:
> https://forum.proxmox.com/threads/schedulded-backup-start-automaticly-when-edited.112055/
you're right, i'll take a look
next prev parent reply other threads:[~2022-07-13 11:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 7:42 [pve-devel] [PATCH manager/docs v2] handle missed jobs better Dominik Csapak
2022-06-02 7:42 ` [pve-devel] [PATCH manager v2 1/3] fix #4026: add 'repeat-missed' option for jobs Dominik Csapak
2022-06-13 12:32 ` Fabian Ebner
2022-06-02 7:42 ` [pve-devel] [PATCH manager v2 2/3] fix #4053: don't run vzdump jobs when they change from disabled->enabled Dominik Csapak
2022-07-13 11:10 ` Fabian Ebner
2022-07-13 11:13 ` Dominik Csapak [this message]
2022-06-02 7:42 ` [pve-devel] [PATCH manager v2 3/3] ui: dc/Backup: add 'repeat-missed' checkbox Dominik Csapak
2022-06-02 7:42 ` [pve-devel] [PATCH docs v2 1/1] vzdump: add section about 'repeat-missed' Dominik Csapak
2022-06-13 12:32 ` [pve-devel] [PATCH manager/docs v2] handle missed jobs better Fabian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84e77301-12bd-3a3a-07d9-b22487e9018d@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox