From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christian Ebner <c.ebner@proxmox.com>
Subject: Re: [pve-devel] [RFC pve-installer v3] fix #6508: auto-installer/post-hook: make iface mac address optional
Date: Mon, 14 Jul 2025 21:27:19 +0200 [thread overview]
Message-ID: <84b54b36-41e0-401f-be76-8ea0de180619@proxmox.com> (raw)
In-Reply-To: <20250711153404.995040-1-c.ebner@proxmox.com>
Am 11.07.25 um 17:34 schrieb Christian Ebner:
> This is a breaking change as it affects the answer file fetch payload,
> the mac address now being optional. The version is therefore bumped.
Meh, not a big fan - we could rather serialize it to "unknown" and not
bump the schema at all, that would IMO be much more pragmatic for us
and admins relying on this already.
Internally it could still be an option, that would make use sites of
that information aware about that it might not be usable.
OTOH, pondering also applying the "just skip" patch for now, while that
might be slightly worse UX, it's a rather unlikely edge case anyway,
especially for servers, where even if such interfaces exists, they are
probably not very likely to be usable after rebooting into the
installed system anyway..
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-14 19:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 15:34 Christian Ebner
2025-07-14 19:27 ` Thomas Lamprecht [this message]
2025-07-15 6:10 ` Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84b54b36-41e0-401f-be76-8ea0de180619@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox