Re: [pve-devel] [PATCH corosync] corosync.service: add patch to reduce log spam in broken network setups

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 04.04.25 um 10:14 schrieb Maximiliano Sandoval:
> Friedrich Weber <f.weber@proxmox.com> writes:

 ...

> An option that might require lower maintenance would be to ship a
> service file override, e.g. at
> /lib/systemd/system/corosync.service.d/set-log-rate-limit.conf with
> contents:
> 
> ```
> [Service]
> LogRateLimitIntervalSec=1s
> LogRateLimitBurst=200
> ```
> 
> No strong feelings, it is just a matter of taste.

Would be more fitting if we did not package corosync our self, as is
this integrated way would be fine to me. That sasid yours could be too.
But ...

> 
>> + 1 file changed, 2 insertions(+)
>> +
>> +diff --git a/init/corosync.service.in b/init/corosync.service.in
>> +index bd2a48a9..3d7ea2db 100644
>> +--- a/init/corosync.service.in
>> ++++ b/init/corosync.service.in
>> +@@ -10,6 +10,8 @@ EnvironmentFile=-@INITCONFIGDIR@/corosync
>> + ExecStart=@SBINDIR@/corosync -f $COROSYNC_OPTIONS
>> + ExecStop=@SBINDIR@/corosync-cfgtool -H --force
>> + Type=notify
>> ++LogRateLimitIntervalSec=1s
>> ++LogRateLimitBurst=200
> 
> 200 hundred messages per second might be a bit too many. Since we are
> not sure how many messages a unlucky user might see, I would suggest to
> lower it a bit for the time being, 100 is a good round number.
> 

... well, this is a core cluster service, having more available from a
log burst is IMO really justified here.

That's also why I won't apply this patch for now, systemd already has
default rate limiting for _very_ noisy stuff, it can also handle high
log rates just fine and this only affects broken setups until they got
fixed.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel