From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [RFC PATCH widget-toolkit] comboGrid: set errorMask on store load failure
Date: Mon, 9 Nov 2020 08:02:12 +0100 [thread overview]
Message-ID: <832b100f-98bd-2c27-09dd-7241f61213c3@proxmox.com> (raw)
In-Reply-To: <20201104141740.365-1-d.csapak@proxmox.com>
On 04.11.20 15:17, Dominik Csapak wrote:
> if there occured an error in the api call of the store, show this error
> on the picker when opened, instead of just showing an empty picker
>
> this makes it possible to see that there was an error while accessing the api
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> altough i tested this, i'd like for someone else to test it too, since
> we basically use this anywhere and i am not sure if i forgot some edge
> case...
>
> src/form/ComboGrid.js | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
>
applied, thanks!
prev parent reply other threads:[~2020-11-09 7:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 14:17 [pve-devel] " Dominik Csapak
2020-11-05 10:09 ` Fabian Grünbichler
2020-11-09 7:02 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=832b100f-98bd-2c27-09dd-7241f61213c3@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox