From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH manager] api: backup: auto-inject job id where expected by the API
Date: Tue, 15 Nov 2022 11:27:17 +0100 [thread overview]
Message-ID: <83261464-afda-cfc1-215a-92acd3675619@proxmox.com> (raw)
In-Reply-To: <20221115101830.59803-1-f.ebner@proxmox.com>
The commit message should include the why too of course rather than just
having it in the code comments:
Am 15.11.22 um 11:18 schrieb Fiona Ebner:
> for backwards compatibility.
When moving the job base plugin to pve-common, the behavior for parsing
the job config changed slightly, and 'id' was not automatically set as a
job property anymore.
> Otherwise, e.g. listing backup jobs with
> pvesh get /cluster/backup is broken. And suddenly not having the
> property anymore would be a breaking API change.
>
Sorry for the noise.
next prev parent reply other threads:[~2022-11-15 10:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 10:18 Fiona Ebner
2022-11-15 10:18 ` [pve-devel] [PATCH common] job registry: remove id property Fiona Ebner
2022-11-15 10:27 ` Fiona Ebner [this message]
2022-11-15 12:30 ` [pve-devel] applied: [PATCH manager] api: backup: auto-inject job id where expected by the API Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83261464-afda-cfc1-215a-92acd3675619@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox