public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
	"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server 1/2] vm_resume: fix nocheck/migrate handling
Date: Mon, 21 Nov 2022 14:08:29 +0100	[thread overview]
Message-ID: <82f6360f-13c9-b80b-cb4d-cb86958efca6@proxmox.com> (raw)
In-Reply-To: <20221121121605.1217-1-f.gruenbichler@proxmox.com>

Am 21/11/2022 um 13:16 schrieb Fabian Grünbichler:
> it's not deterministic whether the rename/move of the VM config
> triggered on the source side of a migration is already visible on the
> target side when vm_resume is executed. check the vmlist for the node
> where the config is currently located if $nocheck is set - it is now
> needed to add the forwarding DB entries to the bridge.
> 
> this fixes an issue on busier or slower clusters, where pmxcfs hasn't
> yet processed the rename, and resuming would fail with an error about
> the config not existing.
> 
> Reported-by: Dominik Csapak <d.csapak@proxmox.com>
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
>  PVE/QemuServer.pm | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
> 
>

applied both patches and fixed up the indentation errors in this one, thanks!




      parent reply	other threads:[~2022-11-21 13:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-21 12:16 [pve-devel] " Fabian Grünbichler
2022-11-21 12:16 ` [pve-devel] [PATCH qemu-server 2/2] explain 'nocheck' in more places Fabian Grünbichler
2022-11-21 13:08 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82f6360f-13c9-b80b-cb4d-cb86958efca6@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal