From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Oguz Bektas <o.bektas@proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 manager] set https_proxy to http_proxy for querying url metadata
Date: Thu, 25 Nov 2021 15:08:24 +0100 [thread overview]
Message-ID: <82e0c5e9-d31d-1366-8dc1-6502e8ec6c67@proxmox.com> (raw)
In-Reply-To: <20211125134803.2320788-1-o.bektas@proxmox.com>
On 25.11.21 14:48, Oguz Bektas wrote:
> Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
where is this tag coming from? Did not see it on the list, only the comment
that it wasn't working?
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
> v1->v2:
> * thanks dominik for catching my error!
>
> PVE/API2/Nodes.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
> index d57a1937..96479848 100644
> --- a/PVE/API2/Nodes.pm
> +++ b/PVE/API2/Nodes.pm
> @@ -1554,7 +1554,7 @@ __PACKAGE__->register_method({
>
> my $dccfg = PVE::Cluster::cfs_read_file('datacenter.cfg');
> if ($dccfg->{http_proxy}) {
> - $ua->proxy('http', $dccfg->{http_proxy});
> + $ua->proxy(['http', 'https'], $dccfg->{http_proxy});
> }
>
> my $verify = $param->{'verify-certificates'} // 1;
>
next prev parent reply other threads:[~2021-11-25 14:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 13:48 Oguz Bektas
2021-11-25 14:08 ` Thomas Lamprecht [this message]
2021-11-25 14:11 ` Oguz Bektas
2021-11-25 14:14 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82e0c5e9-d31d-1366-8dc1-6502e8ec6c67@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=o.bektas@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox