From: Lukas Wagner <l.wagner@proxmox.com>
To: Gabriel Goller <g.goller@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH v3 1/2] log: add perlmod logger and custom formatter
Date: Fri, 6 Dec 2024 10:17:24 +0100 [thread overview]
Message-ID: <82b77900-7239-4cc9-863a-0a3a3ddff5c6@proxmox.com> (raw)
In-Reply-To: <20241205151033.506549-1-g.goller@proxmox.com>
On 2024-12-05 16:10, Gabriel Goller wrote:
> Add special logger for perlmod. This one will print everything to
> stderr (which will end up in the tasklog) and the errors to journald.
> This also includes a custom formatter so that the stderr output will
> look like: "INFO: sample message".
>
> Reported-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> Reported-by: Lukas Wagner <l.wagner@proxmox.com>
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
>
> I didn't include Lukas's T-b as I changed quite a lot on this
> patch.
>
Gave v3 another quick spin, seems to work as advertised. Code also
looks good to me, though I have to say that I don't know much about
the tracing ecosystem.
Tested-by: Lukas Wagner <l.wagner@proxmox.com>
Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
Maybe another set of eyes would be good, as I'm not sure if I'm overlooking some
issue regarding 'always logging to stderr' part in non-task context.
--
- Lukas
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-12-06 9:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-05 15:10 Gabriel Goller
2024-12-05 15:10 ` [pve-devel] [PATCH v3 2/2] log: change default output to stderr and only log errors to journald Gabriel Goller
2024-12-06 9:17 ` Lukas Wagner [this message]
2024-12-09 9:44 ` [pve-devel] [PATCH v3 1/2] log: add perlmod logger and custom formatter Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82b77900-7239-4cc9-863a-0a3a3ddff5c6@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox