From: Dominik Csapak <d.csapak@proxmox.com>
To: Aaron Lauterer <a.lauterer@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 manager 1/3] ui: lxc/qemu: add disk reassign
Date: Fri, 4 Mar 2022 14:32:57 +0100 [thread overview]
Message-ID: <8291ca31-29d4-23f6-99a6-d06aca146a34@proxmox.com> (raw)
In-Reply-To: <01a4001b-4f8e-1678-d460-b1846373085d@proxmox.com>
On 3/4/22 14:29, Aaron Lauterer wrote:
>>> + }); + }, + }); + }, + +
>>> validateForm: function(fp, isValid) { +
>>> this.getView().lookup('submitButton').setDisabled(!isValid); +
>>> }, + + onReassignClick: function() { + let me = this; +
>>> let view = me.getView(); + let form =
>>> view.lookup('moveFormPanel').getForm(); + if
>>> (form.isValid()) { +
>>> me.reassign_disk(form.getValues()); + } + }, + +
>>> onMpTypeChange: function(value) { +
>>> this.getView().getViewModel().set('mpType', value.getValue()); +
>>> this.getView().lookup('mpIdSelector').validate(); + },
>>
>> these functions make me question if it wouldn't have been easier to
>> use an 'edit window' instead? any reason for that?
>
> It has been a while since I sent these patches, but I think there were a few reasons to go with a
> regular window. One of them IIRC was that, similar to the resize and move windows, we also want to
> show a custom labeled button "Reassign {Volume|Disk}" instead of "OK" or one of the options we have
> with the edit window.
>
we have the 'submitText' property for the edit window which always takes precedence
so that shouldn't be the problem
next prev parent reply other threads:[~2022-03-04 13:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 15:02 [pve-devel] [PATCH v2 manager 0/3] ui: lxc/qemu: add reassign for disks and volumes Aaron Lauterer
2021-11-15 15:02 ` [pve-devel] [PATCH v2 manager 1/3] ui: lxc/qemu: add disk reassign Aaron Lauterer
2022-02-21 15:44 ` Dominik Csapak
2022-03-04 13:29 ` Aaron Lauterer
2022-03-04 13:32 ` Dominik Csapak [this message]
2021-11-15 15:02 ` [pve-devel] [PATCH v2 manager 2/3] ui: BusTypeSelector: change noVirtIO to withVirtIO Aaron Lauterer
2021-11-15 15:02 ` [pve-devel] [PATCH v2 manager] ui: hdmove: modernize/refactor Aaron Lauterer
2022-02-22 9:46 ` Dominik Csapak
2022-01-17 10:20 ` [pve-devel] [PATCH v2 manager 0/3] ui: lxc/qemu: add reassign for disks and volumes Aaron Lauterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8291ca31-29d4-23f6-99a6-d06aca146a34@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox