public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH pve_flutter_frontend] chore: assets: update flutter app icons in iOS with proxmox icons
Date: Wed, 21 May 2025 13:27:54 +0200	[thread overview]
Message-ID: <81df0520-361b-44c4-8b22-9499723e9cca@proxmox.com> (raw)
In-Reply-To: <20250519125959.7189-1-s.shaji@proxmox.com>

while i can't test the changes for ios, the images look good,
one question for my curiosity:

what triggered the changes in the Contents.json ?

AFAICS it's just reordering the properties + whitespace changes, which
make it hard to see if there was any actual change to the content...

not that I'm against it, but we should probably not unnecessarily touch these files,
except some tooling (e.g. from flutter) autoformats these or there
are real changes...

On 5/19/25 14:59, Shan Shaji wrote:
> When running the app in iOS the app icon was the default flutter
> icon and this commit fixes it by replacing all
> flutter icons with the proxmox app icon.
> 
> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
> ---
>   .../AppIcon.appiconset/Contents.json          | 160 +++++++++---------
>   .../Icon-App-1024x1024@1x.png                 | Bin 10932 -> 126022 bytes
>   .../AppIcon.appiconset/Icon-App-20x20@1x.png  | Bin 295 -> 692 bytes
>   .../AppIcon.appiconset/Icon-App-20x20@2x.png  | Bin 406 -> 2050 bytes
>   .../AppIcon.appiconset/Icon-App-20x20@3x.png  | Bin 450 -> 3321 bytes
>   .../AppIcon.appiconset/Icon-App-29x29@1x.png  | Bin 282 -> 1425 bytes
>   .../AppIcon.appiconset/Icon-App-29x29@2x.png  | Bin 462 -> 3367 bytes
>   .../AppIcon.appiconset/Icon-App-29x29@3x.png  | Bin 704 -> 5147 bytes
>   .../AppIcon.appiconset/Icon-App-40x40@1x.png  | Bin 406 -> 2050 bytes
>   .../AppIcon.appiconset/Icon-App-40x40@2x.png  | Bin 586 -> 4699 bytes
>   .../AppIcon.appiconset/Icon-App-40x40@3x.png  | Bin 862 -> 7470 bytes
>   .../AppIcon.appiconset/Icon-App-60x60@2x.png  | Bin 862 -> 7470 bytes
>   .../AppIcon.appiconset/Icon-App-60x60@3x.png  | Bin 1674 -> 11744 bytes
>   .../AppIcon.appiconset/Icon-App-76x76@1x.png  | Bin 762 -> 4378 bytes
>   .../AppIcon.appiconset/Icon-App-76x76@2x.png  | Bin 1226 -> 9529 bytes
>   .../Icon-App-83.5x83.5@2x.png                 | Bin 1418 -> 11072 bytes
>   16 files changed, 80 insertions(+), 80 deletions(-)
>   mode change 100644 => 100755 ios/Runner/Assets.xcassets/AppIcon.appiconset/Contents.json
> 
> diff --git a/ios/Runner/Assets.xcassets/AppIcon.appiconset/Contents.json b/ios/Runner/Assets.xcassets/AppIcon.appiconset/Contents.json
> old mode 100644
> new mode 100755
> index d36b1fa..9b6d103
> --- a/ios/Runner/Assets.xcassets/AppIcon.appiconset/Contents.json
> +++ b/ios/Runner/Assets.xcassets/AppIcon.appiconset/Contents.json
> @@ -1,122 +1,122 @@
>   {
> -  "images" : [
> +  "images": [
>       {
> -      "size" : "20x20",
> -      "idiom" : "iphone",
> -      "filename" : "Icon-App-20x20@2x.png",
> -      "scale" : "2x"
> +      "idiom": "iphone",
> +      "size": "20x20",
> +      "scale": "2x",
> +      "filename": "Icon-App-20x20@2x.png"
>       },
>       {
> -      "size" : "20x20",
> -      "idiom" : "iphone",
> -      "filename" : "Icon-App-20x20@3x.png",
> -      "scale" : "3x"
> +      "idiom": "iphone",
> +      "size": "20x20",
> +      "scale": "3x",
> +      "filename": "Icon-App-20x20@3x.png"
>       },
>       {
> -      "size" : "29x29",
> -      "idiom" : "iphone",
> -      "filename" : "Icon-App-29x29@1x.png",
> -      "scale" : "1x"
> +      "idiom": "iphone",
> +      "size": "29x29",
> +      "scale": "1x",
> +      "filename": "Icon-App-29x29@1x.png"
>       },
>       {
> -      "size" : "29x29",
> -      "idiom" : "iphone",
> -      "filename" : "Icon-App-29x29@2x.png",
> -      "scale" : "2x"
> +      "idiom": "iphone",
> +      "size": "29x29",
> +      "scale": "2x",
> +      "filename": "Icon-App-29x29@2x.png"
>       },
>       {
> -      "size" : "29x29",
> -      "idiom" : "iphone",
> -      "filename" : "Icon-App-29x29@3x.png",
> -      "scale" : "3x"
> +      "idiom": "iphone",
> +      "size": "29x29",
> +      "scale": "3x",
> +      "filename": "Icon-App-29x29@3x.png"
>       },
>       {
> -      "size" : "40x40",
> -      "idiom" : "iphone",
> -      "filename" : "Icon-App-40x40@2x.png",
> -      "scale" : "2x"
> +      "idiom": "iphone",
> +      "size": "40x40",
> +      "scale": "2x",
> +      "filename": "Icon-App-40x40@2x.png"
>       },
>       {
> -      "size" : "40x40",
> -      "idiom" : "iphone",
> -      "filename" : "Icon-App-40x40@3x.png",
> -      "scale" : "3x"
> +      "idiom": "iphone",
> +      "size": "40x40",
> +      "scale": "3x",
> +      "filename": "Icon-App-40x40@3x.png"
>       },
>       {
> -      "size" : "60x60",
> -      "idiom" : "iphone",
> -      "filename" : "Icon-App-60x60@2x.png",
> -      "scale" : "2x"
> +      "idiom": "iphone",
> +      "size": "60x60",
> +      "scale": "2x",
> +      "filename": "Icon-App-60x60@2x.png"
>       },
>       {
> -      "size" : "60x60",
> -      "idiom" : "iphone",
> -      "filename" : "Icon-App-60x60@3x.png",
> -      "scale" : "3x"
> +      "idiom": "iphone",
> +      "size": "60x60",
> +      "scale": "3x",
> +      "filename": "Icon-App-60x60@3x.png"
>       },
>       {
> -      "size" : "20x20",
> -      "idiom" : "ipad",
> -      "filename" : "Icon-App-20x20@1x.png",
> -      "scale" : "1x"
> +      "idiom": "ipad",
> +      "size": "20x20",
> +      "scale": "1x",
> +      "filename": "Icon-App-20x20@1x.png"
>       },
>       {
> -      "size" : "20x20",
> -      "idiom" : "ipad",
> -      "filename" : "Icon-App-20x20@2x.png",
> -      "scale" : "2x"
> +      "idiom": "ipad",
> +      "size": "20x20",
> +      "scale": "2x",
> +      "filename": "Icon-App-20x20@2x.png"
>       },
>       {
> -      "size" : "29x29",
> -      "idiom" : "ipad",
> -      "filename" : "Icon-App-29x29@1x.png",
> -      "scale" : "1x"
> +      "idiom": "ipad",
> +      "size": "29x29",
> +      "scale": "1x",
> +      "filename": "Icon-App-29x29@1x.png"
>       },
>       {
> -      "size" : "29x29",
> -      "idiom" : "ipad",
> -      "filename" : "Icon-App-29x29@2x.png",
> -      "scale" : "2x"
> +      "idiom": "ipad",
> +      "size": "29x29",
> +      "scale": "2x",
> +      "filename": "Icon-App-29x29@2x.png"
>       },
>       {
> -      "size" : "40x40",
> -      "idiom" : "ipad",
> -      "filename" : "Icon-App-40x40@1x.png",
> -      "scale" : "1x"
> +      "idiom": "ipad",
> +      "size": "40x40",
> +      "scale": "1x",
> +      "filename": "Icon-App-40x40@1x.png"
>       },
>       {
> -      "size" : "40x40",
> -      "idiom" : "ipad",
> -      "filename" : "Icon-App-40x40@2x.png",
> -      "scale" : "2x"
> +      "idiom": "ipad",
> +      "size": "40x40",
> +      "scale": "2x",
> +      "filename": "Icon-App-40x40@2x.png"
>       },
>       {
> -      "size" : "76x76",
> -      "idiom" : "ipad",
> -      "filename" : "Icon-App-76x76@1x.png",
> -      "scale" : "1x"
> +      "idiom": "ipad",
> +      "size": "76x76",
> +      "scale": "1x",
> +      "filename": "Icon-App-76x76@1x.png"
>       },
>       {
> -      "size" : "76x76",
> -      "idiom" : "ipad",
> -      "filename" : "Icon-App-76x76@2x.png",
> -      "scale" : "2x"
> +      "idiom": "ipad",
> +      "size": "76x76",
> +      "scale": "2x",
> +      "filename": "Icon-App-76x76@2x.png"
>       },
>       {
> -      "size" : "83.5x83.5",
> -      "idiom" : "ipad",
> -      "filename" : "Icon-App-83.5x83.5@2x.png",
> -      "scale" : "2x"
> +      "idiom": "ipad",
> +      "size": "83.5x83.5",
> +      "scale": "2x",
> +      "filename": "Icon-App-83.5x83.5@2x.png"
>       },
>       {
> -      "size" : "1024x1024",
> -      "idiom" : "ios-marketing",
> -      "filename" : "Icon-App-1024x1024@1x.png",
> -      "scale" : "1x"
> +      "size": "1024x1024",
> +      "idiom": "ios-marketing",
> +      "scale": "1x",
> +      "filename": "Icon-App-1024x1024@1x.png"
>       }
>     ],
> -  "info" : {
> -    "version" : 1,
> -    "author" : "xcode"
> +  "info": {
> +    "version": 1,
> +    "author": "xcode"
>     }
>   }
[snipped all the binary diffs]


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2025-05-21 11:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-19 12:59 Shan Shaji
2025-05-21 11:27 ` Dominik Csapak [this message]
2025-05-22  9:33   ` Shan Shaji

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81df0520-361b-44c4-8b22-9499723e9cca@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal