From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server] fix #3608: unbreak removal of scsi controller
Date: Thu, 9 Sep 2021 17:53:19 +0200 [thread overview]
Message-ID: <80c2e6fd-4540-4fd0-d051-573c9e1ff656@proxmox.com> (raw)
In-Reply-To: <20210909124042.2900922-1-f.gruenbichler@proxmox.com>
On 09.09.21 14:40, Fabian Grünbichler wrote:
> the assumption that the index of the controller matches that of the last
> removed drive only holds for virtio-scsi-single controller, which makes
> the old code print a warning when removing the last drive of a
> non-virtio-scsi-single controller except when the indices line up by
> chance.
>
> we can simply only call a simplified qemu_iothread_del when removing a
> scsi disk of a VM with the virtio-scsi-single controller, and skip the
> call for the other controllers which don't support io-threads anyway.
>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> alternatively we could keep the old version but conditionally only call
> it for virtioscsi.* and not for scsihw.*, but the now aligned signature
> for adding and removing iothread objects seems like a nice bonus to me
> ;)
>
> PVE/QemuServer.pm | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
>
applied, thanks! Thrown in some white space/indentation fixes I noticed in the
surrounding code when checking out this patch more closely.
prev parent reply other threads:[~2021-09-09 15:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 12:40 [pve-devel] " Fabian Grünbichler
2021-09-09 15:53 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80c2e6fd-4540-4fd0-d051-573c9e1ff656@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox