public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Friedrich Weber <f.weber@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
	Maximiliano Sandoval <m.sandoval@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH corosync] corosync.service: add patch to reduce log spam in broken network setups
Date: Fri, 4 Apr 2025 14:43:51 +0200	[thread overview]
Message-ID: <80baf0ca-51da-4b7c-b49d-8d238d1793a9@proxmox.com> (raw)
In-Reply-To: <327a96ce-6884-445d-9bc2-6b94e68662f6@proxmox.com>

On 04/04/2025 11:40, Thomas Lamprecht wrote:
>> I am starting to lean towards not limiting this here. However, I have
>> seen multiple instances at our support portal where logs are rotated
>> rather quickly and useful messages are lost.
> 
> In dmesg (kernel ring buffer) sure, but the systemd journal should not
> really be affected of such limitations, and such similar logs should
> compress very well and not cause that much growth.
> And FWIW rate-limiting is also a loss of logs, so it's really a trade
> of.
> 
> If more than a handful of people run into this, we can also add the
> rate-limit log stanza to the release notes known issue section (where
> a general entry might be nice in any way) with direction for how to
> create a systemd service override similar to Maximiliano's proposal
> but for /etc. People can also always downgrade.

OK, sounds good!

> I'm just not comfortable rate-limiting such an important service with
> the justifications presented so far.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      reply	other threads:[~2025-04-04 12:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-04  7:59 Friedrich Weber
2025-04-04  8:14 ` Maximiliano Sandoval
2025-04-04  8:55   ` Thomas Lamprecht
2025-04-04  9:18     ` Friedrich Weber
2025-04-04  9:28       ` Maximiliano Sandoval
2025-04-04  9:40         ` Thomas Lamprecht
2025-04-04 12:43           ` Friedrich Weber [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=80baf0ca-51da-4b7c-b49d-8d238d1793a9@proxmox.com \
    --to=f.weber@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal