From: Daniel Kral <d.kral@proxmox.com>
To: Christoph Heiss <c.heiss@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH installer] fix #5984: unconfigured: do not reboot if auto-installer fails by default
Date: Wed, 8 Jan 2025 16:26:54 +0100 [thread overview]
Message-ID: <805a670a-215b-4ec9-8330-93365146e03a@proxmox.com> (raw)
In-Reply-To: <D6DWJ7ZFFZO7.2P2Y42U1UBIBK@proxmox.com>
On 12/17/24 11:26, Christoph Heiss wrote:
> But this still doesn't really fix the issue by honoring the
> `global.reboot_on_error` flag in any way, but just inverts the current
> behaviour?
> I.e. now it just always drops into the a shell, w/o ever auto-rebooting,
> even if `global.reboot_on_error = true`.
Yes, sorry that you had to find out while testing! I should have noticed
the error in logic. I'm sending a v2!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-01-08 15:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 16:14 Daniel Kral
2024-12-17 10:26 ` Christoph Heiss
2025-01-08 15:26 ` Daniel Kral [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=805a670a-215b-4ec9-8330-93365146e03a@proxmox.com \
--to=d.kral@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox