From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Robert Obkircher <r.obkircher@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-manager] fix #6443: ui: Improve onlineHelp for VM State storage
Date: Fri, 31 Oct 2025 17:14:45 +0100 [thread overview]
Message-ID: <804e4302-72e7-4f44-b1db-b47648f4d7d6@proxmox.com> (raw)
In-Reply-To: <20251031123532.79418-1-r.obkircher@proxmox.com>
Thanks for your patch, changewise it looks OK, but having more context is
always really nice for others, here it would be great to mention the pve-docs
version that the reference became available.
And note that this pve-docs version effectively is then also a build-requirement,
so you might need to increase the versioned build-dependency for pve-docs in the
debian/control file, at least if that isn't already requiring a higher version
there, with that the build will then fail early and not only later.
Am 31.10.25 um 13:36 schrieb Robert Obkircher:
> Signed-off-by: Robert Obkircher <r.obkircher@proxmox.com>
> ---
> www/manager6/qemu/Options.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/manager6/qemu/Options.js b/www/manager6/qemu/Options.js
> index 6fe96fe2..bfa39c76 100644
> --- a/www/manager6/qemu/Options.js
> +++ b/www/manager6/qemu/Options.js
> @@ -352,7 +352,7 @@ Ext.define('PVE.qemu.Options', {
> ? {
> xtype: 'proxmoxWindowEdit',
> subject: gettext('VM State storage'),
> - onlineHelp: 'chapter_virtual_machines', // FIXME: use 'qm_vmstatestorage' once available
> + onlineHelp: 'qm_vmstatestorage',
> width: 350,
> items: {
> xtype: 'pveStorageSelector',
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-10-31 16:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-31 12:35 Robert Obkircher
2025-10-31 16:14 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=804e4302-72e7-4f44-b1db-b47648f4d7d6@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=r.obkircher@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox