From: Gabriel Goller <g.goller@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-ve-rs v7 06/21] frr: add isis configuration and templates
Date: Fri, 27 Mar 2026 10:53:03 +0100 [thread overview]
Message-ID: <7sqz543ysqepnk5rusebnc3m24uzndixp2p5ppxg7cvrev4u7j@7qju22xss26p> (raw)
In-Reply-To: <d6a12b5a-f885-4302-9a68-2f74a5101052@proxmox.com>
On 27.03.2026 01:41, Thomas Lamprecht wrote:
> Am 23.03.26 um 14:51 schrieb Gabriel Goller:
> > +++ b/proxmox-frr-templates/templates/isisd.jinja
> > +{% if router_config.redistribute.ipv4_connected %}
> > + redistribute ipv4 connected {{ router_config.redistribute.ipv4_connected }}
> > +{% endif %}
> > +{% if router_config.redistribute.ipv6_connected %}
> > + redistribute ipv6 connected {{ router_config.redistribute.ipv6_connected }}
> > +{% endif %}
>
> This accesses .ipv4_connected on redistribute without first checking that
> redistribute is non-null. With minijinja strict mode (enabled in patch 09/21),
> the null.attr evaluates to undefined, which is falsy in {% if %} so it happens
> to work, but it's a bit fragile. An outer guard would be cleaner:
>
> {% if router_config.redistribute %}
> {% if router_config.redistribute.ipv4_connected %}
> ...
Agree, thanks!
next prev parent reply other threads:[~2026-03-27 9:52 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 13:48 [PATCH manager/network/proxmox{-ve-rs,-perl-rs} v7 00/21] Generate frr config using jinja templates and rust types Gabriel Goller
2026-03-23 13:48 ` [PATCH proxmox-ve-rs v7 01/21] ve-config: firewall: cargo fmt Gabriel Goller
2026-03-23 13:48 ` [PATCH proxmox-ve-rs v7 02/21] frr: add proxmox-frr-templates package that contains templates Gabriel Goller
2026-03-26 15:15 ` Shannon Sterz
2026-03-27 9:07 ` Gabriel Goller
2026-03-27 9:12 ` Gabriel Goller
2026-03-27 10:10 ` Thomas Lamprecht
2026-03-27 10:17 ` Gabriel Goller
2026-03-23 13:48 ` [PATCH proxmox-ve-rs v7 03/21] ve-config: remove FrrConfigBuilder struct Gabriel Goller
2026-03-23 13:48 ` [PATCH proxmox-ve-rs v7 04/21] sdn-types: support variable-length NET identifier Gabriel Goller
2026-03-26 15:15 ` Shannon Sterz
2026-03-27 9:25 ` Gabriel Goller
2026-03-23 13:48 ` [PATCH proxmox-ve-rs v7 05/21] frr: add template serializer and serialize fabrics using templates Gabriel Goller
2026-03-27 0:37 ` Thomas Lamprecht
2026-03-27 9:45 ` Gabriel Goller
2026-03-23 13:48 ` [PATCH proxmox-ve-rs v7 06/21] frr: add isis configuration and templates Gabriel Goller
2026-03-27 0:41 ` Thomas Lamprecht
2026-03-27 9:53 ` Gabriel Goller [this message]
2026-03-23 13:48 ` [PATCH proxmox-ve-rs v7 07/21] frr: support custom frr configuration lines Gabriel Goller
2026-03-23 13:48 ` [PATCH proxmox-ve-rs v7 08/21] frr: add bgp support with templates and serialization Gabriel Goller
2026-03-27 0:50 ` Thomas Lamprecht
2026-03-27 10:05 ` Gabriel Goller
2026-03-23 13:48 ` [PATCH proxmox-ve-rs v7 09/21] frr: enable minijinja strict undefined behavior mode Gabriel Goller
2026-03-23 13:49 ` [PATCH proxmox-ve-rs v7 10/21] frr: add vtysh integration tests for proxmox-frr Gabriel Goller
2026-03-24 9:03 ` Gabriel Goller
2026-03-23 13:49 ` [PATCH proxmox-perl-rs v7 11/21] sdn: add function to generate the frr config for all daemons Gabriel Goller
2026-03-23 13:49 ` [PATCH pve-network v7 12/21] tests: use Test::Differences to make test assertions Gabriel Goller
2026-03-23 13:49 ` [PATCH pve-network v7 13/21] test: add tests for frr.conf.local merging Gabriel Goller
2026-03-23 13:49 ` [PATCH pve-network v7 14/21] test: bgp: add some various integration tests Gabriel Goller
2026-03-23 13:49 ` [PATCH pve-network v7 15/21] sdn: write structured frr config that can be rendered using templates Gabriel Goller
2026-03-23 13:49 ` [PATCH pve-network v7 16/21] sdn: remove duplicate comment line '!' in frr config Gabriel Goller
2026-03-23 13:49 ` [PATCH pve-network v7 17/21] tests: rearrange some statements in the " Gabriel Goller
2026-03-23 13:49 ` [PATCH pve-network v7 18/21] sdn: adjust frr.conf.local merging to rust template types Gabriel Goller
2026-03-23 13:49 ` [PATCH pve-network v7 19/21] test: adjust frr_local_merge test for new template generation Gabriel Goller
2026-03-23 13:49 ` [PATCH pve-network v7 20/21] api: add dry-run endpoint for sdn apply to preview changes Gabriel Goller
2026-03-27 1:07 ` Thomas Lamprecht
2026-03-23 13:49 ` [PATCH pve-manager v7 21/21] sdn: add dry-run diff view for sdn apply Gabriel Goller
2026-03-26 13:40 ` [PATCH manager/network/proxmox{-ve-rs,-perl-rs} v7 00/21] Generate frr config using jinja templates and rust types Wolfgang Bumiller
2026-03-27 1:11 ` Thomas Lamprecht
2026-03-27 10:06 ` Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7sqz543ysqepnk5rusebnc3m24uzndixp2p5ppxg7cvrev4u7j@7qju22xss26p \
--to=g.goller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox