public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christoph Heiss <c.heiss@proxmox.com>
To: Gilberto Ferreira <gilberto.nunes32@gmail.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	 Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: Re: [pve-devel] [PATCH installer v2 1/6] fix #4829: install: add new ZFS `arc_max` setup option
Date: Wed, 25 Oct 2023 10:28:02 +0200	[thread overview]
Message-ID: <7l5h7ecjzznfpagtvnk7xcp7s2cu7njnnext2dp4zcwgyxbk3p@r5nlqvepijry> (raw)
In-Reply-To: <mailman.181.1698148853.385.pve-devel@lists.proxmox.com>


On Tue, Oct 24, 2023 at 08:59:36AM -0300, Gilberto Ferreira via pve-devel wrote:
> Date: Tue, 24 Oct 2023 08:59:36 -0300
> From: Gilberto Ferreira <gilberto.nunes32@gmail.com>
> To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
> Subject: Re: [pve-devel] [PATCH installer v2 1/6] fix #4829: install: add
>  new ZFS `arc_max` setup option
>
>
> Hi there.
> Now, that's a good option in the installer.
> I wonder if this option will be available post-intall, like some box in the
> ZFS manager from WEB GUI!
> That's would be nice.
>

Currently, this isn't planned, although - since that setting is exposed
after all in the installer in the future - it would be kind of sensible
to add it to the GUI as well, I guess.
But as a separate series from this one, of course.

CC @Thomas - what do you think?

If you think this is something worth doing, I'd create a proper bugzilla
ticket with some more details.

My thinking here (roughly) would be:

* Move the {default,clamp}_zfs_arc_max() stuff to pve-common
* As for the API, probably shove it under `/nodes/{node}/config`?
  It's a per-node configuration after all, it seems to fit there best
  without introducing another endpoint just for this
* GUI-wise; if we do the above, it probably should also go under node ->
  system -> options ..
  Otherwise, add a small, separate panel for options to node -> disks ->
  zfs maybe?




  parent reply	other threads:[~2023-10-25  8:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-24 11:55 [pve-devel] [PATCH installer v2 0/6] fix #4829: set up lower default limit for ZFS ARC in installer Christoph Heiss
2023-10-24 11:55 ` [pve-devel] [PATCH installer v2 1/6] fix #4829: install: add new ZFS `arc_max` setup option Christoph Heiss
2023-10-24 15:05   ` Thomas Lamprecht
2023-10-25  8:17     ` Christoph Heiss
     [not found]   ` <mailman.181.1698148853.385.pve-devel@lists.proxmox.com>
2023-10-25  8:28     ` Christoph Heiss [this message]
2023-10-25 17:09       ` Thomas Lamprecht
2023-10-27  8:29         ` Christoph Heiss
2023-10-24 11:55 ` [pve-devel] [PATCH installer v2 2/6] fix #4829: proxinstall: expose new `arc_max` ZFS option for PVE installations Christoph Heiss
2023-10-24 11:55 ` [pve-devel] [PATCH installer v2 3/6] fix #4829: test: add tests for new zfs_arc_max calculations Christoph Heiss
2023-10-24 11:55 ` [pve-devel] [PATCH installer v2 4/6] tui: views: add optional suffix label for `NumericEditView`s Christoph Heiss
2023-10-24 11:55 ` [pve-devel] [PATCH installer v2 5/6] fix #4829: tui: setup: add new ZFS `arc_max` option Christoph Heiss
2023-10-24 11:55 ` [pve-devel] [PATCH installer v2 6/6] fix #4829: tui: bootdisk: expose new `arc_max` ZFS option for PVE installations Christoph Heiss
2023-10-24 15:07 ` [pve-devel] [PATCH installer v2 0/6] fix #4829: set up lower default limit for ZFS ARC in installer Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7l5h7ecjzznfpagtvnk7xcp7s2cu7njnnext2dp4zcwgyxbk3p@r5nlqvepijry \
    --to=c.heiss@proxmox.com \
    --cc=gilberto.nunes32@gmail.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal