public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH manager 1/2] ui: clone: validate name
Date: Mon, 24 Apr 2023 12:10:31 +0200	[thread overview]
Message-ID: <7f382106-6011-c33a-1201-0bf1f069aca9@proxmox.com> (raw)
In-Reply-To: <20230417070914.13808-1-f.ebner@proxmox.com>

On 17/04/2023 09:09, Fiona Ebner wrote:
> As reported in the community forum[0], as opposed to VM/LXC creation,
> there is no validation for the name in the clone dialog. Use the same
> validation as the guest creation wizards do to catch errors early,
> before sending the API request.
> 
> [0]: https://forum.proxmox.com/threads/125883/#post-549304
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>  www/manager6/window/Clone.js | 1 +
>  1 file changed, 1 insertion(+)
> 
>

applied both patches, thanks!




      parent reply	other threads:[~2023-04-24 10:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-17  7:09 [pve-devel] " Fiona Ebner
2023-04-17  7:09 ` [pve-devel] [PATCH manager 2/2] ui: backup restore: " Fiona Ebner
2023-04-24 10:10 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7f382106-6011-c33a-1201-0bf1f069aca9@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal