Re: [pve-devel] [PATCH v2 pve-storage 2/2] fix #6941 : lvmplugin : fix activation on secure delete

[Fiona Ebner <f.ebner@proxmox.com>]

Am 22.10.25 um 11:12 AM schrieb Fiona Ebner:
> Am 21.10.25 um 4:01 PM schrieb Alexandre Derumier via pve-devel:
>> @@ -777,11 +781,7 @@ sub free_image {
>>          #activate volumes && snapshot volumes
> 
> This comment is misleading now. It should note that snapshots are
> activated later in free_lvm_volumes() if needed for zeroing.
> 
>>          my $path = $class->path($scfg, $volname, $storeid);
>>          $path = "\@pve-$name" if $format && $format eq 'qcow2';
> 
> The $path variable is not used anymore and can be dropped.
> 
> On another note, the way of using tags like "@pve-vm-105-disk-2.qcow2"
> is not quite correct, because there might be multiple LVM storages with
> qcow2 and volumes with the same name. And those then should not be
> tagged the same, but currently are. While it's probably very rare to
> come across such a setup, it's not impossible and could lead to
> hard-to-debug issues down the line. But it's out of scope for the
> current series.

Addendum: an approach would be including the storage ID in the tag, but
then renaming a storage would cause breakage and it wouldn't help for
existing setups. Most robust would be to use a list of explicit LVs when
issuing lvchange commands.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel