From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH v3 qemu 1/2] fix #5409: backup: fix copy-before-write timeout
Date: Tue, 30 Apr 2024 09:45:22 +0200 [thread overview]
Message-ID: <7ee6db08-8650-4836-ad1a-d255a08d1335@proxmox.com> (raw)
In-Reply-To: <20240429152022.478234-1-f.ebner@proxmox.com>
On 29/04/2024 17:20, Fiona Ebner wrote:
> The type for the copy-before-write timeout in nanoseconds was wrong.
> By being just uint32_t, a maximum of slightly over 4 seconds was
> possible. Larger values would overflow and thus the 45 seconds set by
> Proxmox's backup with fleecing, resulted in effectively 2 seconds
> timeout for copy-before-write operations.
>
> Reported-by: Friedrich Weber <f.weber@proxmox.com>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>
> Changes in v3:
> * rebase on master
>
> Upstream submission of this patch:
> https://lore.kernel.org/qemu-devel/20240429141934.442154-1-f.ebner@proxmox.com/T/#u
>
> ...e-write-use-uint64_t-for-timeout-in-.patch | 35 +++++++++++++++++++
> ...ock-copy-before-write-fix-permission.patch | 2 +-
> ...e-write-support-unligned-snapshot-di.patch | 2 +-
> ...e-write-create-block_copy-bitmap-in-.patch | 2 +-
> ...-backup-add-discard-source-parameter.patch | 4 +--
> ...e-allow-specifying-minimum-cluster-s.patch | 2 +-
> ...um-cluster-size-to-performance-optio.patch | 2 +-
> debian/patches/series | 1 +
> 8 files changed, 43 insertions(+), 7 deletions(-)
> create mode 100644 debian/patches/extra/0005-block-copy-before-write-use-uint64_t-for-timeout-in-.patch
>
>
applied series, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-04-30 7:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 15:20 [pve-devel] " Fiona Ebner
2024-04-29 15:20 ` [pve-devel] [PATCH v3 qemu 2/2] backup: improve error when copy-before-write fails for fleecing Fiona Ebner
2024-04-30 7:45 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ee6db08-8650-4836-ad1a-d255a08d1335@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox