From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Max Carrara <m.carrara@proxmox.com>
Cc: Lukas Wagner <l.wagner@proxmox.com>
Subject: [pve-devel] partially-applied-series: [PATCH v2 pve-manager 00/10] Ceph Build Commit in UI
Date: Mon, 22 Jul 2024 17:40:23 +0200 [thread overview]
Message-ID: <7edc55e4-9e61-455e-978f-17ea0b99e9b1@proxmox.com> (raw)
In-Reply-To: <20240701141040.643701-1-m.carrara@proxmox.com>
Am 01/07/2024 um 16:10 schrieb Max Carrara:
> Ceph Build Commit in UI - Version 2
> ===================================
>
> Notable Changes since v1
> ------------------------
>
> * Use camelCase instead of snake_case for new functions / variables
> as per our style guide [0] (thanks Lukas!)
> * Refrain from using `const` for things that aren't actual constants
> as per our style guide [1] (thanks Lukas!)
> * NEW: Patch 09: Increase the default width of the version field in
> the OSD tree so that longer strings are immediately readable without
> needing to adjust the column widths manually
> --> e.g. "18.2.2 (e9fe820e7 -> 69ce99eba)" takes up a lot of space
> in the column
> * NEW: Patch 10: Include Ceph build commit in the version string
> which is part of the object of the `ceph/osd/{osdid}/metadata` call
>
> For a detailed list of changes, please see the comments in the
> individual patches.
>
> NOTE: I added Lukas's T-b and R-b tags to all patches except the new
> ones, as mentioned in a reply to v1 [2].
>
> Older Versions
> --------------
>
> v1: https://lists.proxmox.com/pipermail/pve-devel/2024-April/063772.html
>
> References
> ----------
>
> [0]: https://pve.proxmox.com/wiki/Javascript_Style_Guide#Casing
> [1]: https://pve.proxmox.com/wiki/Javascript_Style_Guide#Variables
> [2]: https://lists.proxmox.com/pipermail/pve-devel/2024-June/064084.html
>
> Summary of Changes
> ------------------
>
> Max Carrara (10):
> ceph: tools: refactor installation check as guard clause
> ceph: tools: parse Ceph version in separate sub and update regex
> ceph: services: remove old cluster broadcast
> ceph: services: refactor version existence check as guard clause
> utils: align regex of parse_ceph_version with Perl equivalent
applied above 5 clean-up patches already, thanks!
> ui: ceph: services: parse and display build commit
> api: ceph: add build commit of host to Ceph osd index endpoint data
> ui: ceph: osd: rework rendering of version field & show build commit
> ui: ceph: osd: increase width of version column
> api: ceph: change version format in OSD metadata endpoint
>
> PVE/API2/Ceph/OSD.pm | 9 ++++-
> PVE/Ceph/Services.pm | 38 ++++++++++----------
> PVE/Ceph/Tools.pm | 59 ++++++++++++++++++++++----------
> www/manager6/Utils.js | 17 ++++++++-
> www/manager6/ceph/OSD.js | 57 +++++++++++++++++++++++++-----
> www/manager6/ceph/ServiceList.js | 32 +++++++++++++----
> www/manager6/ceph/Services.js | 14 +++++++-
> 7 files changed, 170 insertions(+), 56 deletions(-)
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-07-22 15:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 14:10 [pve-devel] " Max Carrara
2024-07-01 14:10 ` [pve-devel] [PATCH v2 pve-manager 01/10] ceph: tools: refactor installation check as guard clause Max Carrara
2024-07-01 14:10 ` [pve-devel] [PATCH v2 pve-manager 02/10] ceph: tools: parse Ceph version in separate sub and update regex Max Carrara
2024-07-01 14:10 ` [pve-devel] [PATCH v2 pve-manager 03/10] ceph: services: remove old cluster broadcast Max Carrara
2024-07-01 14:10 ` [pve-devel] [PATCH v2 pve-manager 04/10] ceph: services: refactor version existence check as guard clause Max Carrara
2024-07-01 14:10 ` [pve-devel] [PATCH v2 pve-manager 05/10] utils: align regex of parse_ceph_version with Perl equivalent Max Carrara
2024-07-01 14:10 ` [pve-devel] [PATCH v2 pve-manager 06/10] ui: ceph: services: parse and display build commit Max Carrara
2024-07-22 15:38 ` Thomas Lamprecht
2024-07-23 6:49 ` Max Carrara
2024-07-01 14:10 ` [pve-devel] [PATCH v2 pve-manager 07/10] api: ceph: add build commit of host to Ceph osd index endpoint data Max Carrara
2024-07-01 14:10 ` [pve-devel] [PATCH v2 pve-manager 08/10] ui: ceph: osd: rework rendering of version field & show build commit Max Carrara
2024-07-01 14:10 ` [pve-devel] [PATCH v2 pve-manager 09/10] ui: ceph: osd: increase width of version column Max Carrara
2024-07-01 14:10 ` [pve-devel] [PATCH v2 pve-manager 10/10] api: ceph: change version format in OSD metadata endpoint Max Carrara
2024-07-02 14:17 ` [pve-devel] [PATCH v2 pve-manager 00/10] Ceph Build Commit in UI Max Carrara
2024-07-19 12:17 ` Igor Moritz Thaller
2024-07-22 5:29 ` Max Carrara
2024-07-22 15:40 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7edc55e4-9e61-455e-978f-17ea0b99e9b1@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=m.carrara@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox