Re: [pve-devel] [pbs-devel] [PATCH v2 proxmox-backup 1/2] GUI: CSS: remove redundant action column style

[Matthias Heiserer <m.heiserer@proxmox.com>]

On 28.11.2022 08:32, Thomas Lamprecht wrote:
> Am 07/10/2022 um 13:18 schrieb Matthias Heiserer:
>> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
>> ---
>>
>> Changes from v1:
>> remove both action column styles
>>
>>   www/css/ext6-pbs.css | 14 --------------
>>   1 file changed, 14 deletions(-)
>>
>> diff --git a/www/css/ext6-pbs.css b/www/css/ext6-pbs.css
>> index 3c8bed55..7fc60eee 100644
>> --- a/www/css/ext6-pbs.css
>> +++ b/www/css/ext6-pbs.css
>> @@ -127,20 +127,6 @@ table:not(.x-grid-item-selected) tr.x-grid-row.disabled {
>>       color: #cfcfcf;
>>   }
>>   
>> -/* fix action column icons */
>> -.x-action-col-icon {
>> -    font-size: 13px;
>> -    height: 13px;
>> -}
>> -
>> -.x-grid-cell-inner-action-col {
>> -    padding: 6px 10px 5px;
>> -}
> 
> ^- above rule gets lost and bloats up vertical padding quite a bit in the progress,
> there's no commit message so a bit hard to tell, but just from the subject I'd think
> that this is meant to be done, or?
I figured we want to have the same style on all products.
Should I send a v2 and keep this line in PBS, or add it to the widget 
toolkit?

> 
>> -
>> -.x-action-col-icon:before {
>> -    color: #555;
>> -}
>> -
>>   .x-treelist-item-icon {
>>       color: #000;
>>   }
>