* [pve-devel] [PATCH manager] fix #4605: drop rsyncable from zstd invocation
@ 2023-04-17 7:04 Fabian Grünbichler
2023-06-06 17:14 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Grünbichler @ 2023-04-17 7:04 UTC (permalink / raw)
To: pve-devel
it causes severe slow downs on fast disks, and we still have other rsyncable
compressors available.
it was originally added based on wrong documentation that made the performance
impact look a lot smaller than it actually is.
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
Notes:
IMHO, we can always re-introduce it as configurable opt-in option if somebody
really needs this combination.. and most things for which you might want
rsyncable are better off just using PBS nowadays anyway.
PVE/VZDump.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
index a04837e7..f574950e 100644
--- a/PVE/VZDump.pm
+++ b/PVE/VZDump.pm
@@ -757,7 +757,7 @@ sub compressor_info {
my $cpuinfo = PVE::ProcFSTools::read_cpuinfo();
$zstd_threads = int(($cpuinfo->{cpus} + 1)/2);
}
- return ("zstd --rsyncable --threads=${zstd_threads}", 'zst');
+ return ("zstd --threads=${zstd_threads}", 'zst');
} else {
die "internal error - unknown compression option '$opt_compress'";
}
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH manager] fix #4605: drop rsyncable from zstd invocation
2023-04-17 7:04 [pve-devel] [PATCH manager] fix #4605: drop rsyncable from zstd invocation Fabian Grünbichler
@ 2023-06-06 17:14 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2023-06-06 17:14 UTC (permalink / raw)
To: Proxmox VE development discussion, Fabian Grünbichler
Am 17/04/2023 um 09:04 schrieb Fabian Grünbichler:
> it causes severe slow downs on fast disks, and we still have other rsyncable
> compressors available.
>
> it was originally added based on wrong documentation that made the performance
> impact look a lot smaller than it actually is.
>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
>
> Notes:
> IMHO, we can always re-introduce it as configurable opt-in option if somebody
> really needs this combination.. and most things for which you might want
> rsyncable are better off just using PBS nowadays anyway.
>
> PVE/VZDump.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-06 17:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-17 7:04 [pve-devel] [PATCH manager] fix #4605: drop rsyncable from zstd invocation Fabian Grünbichler
2023-06-06 17:14 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox