public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
	"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] fix #4605: drop rsyncable from zstd invocation
Date: Tue, 6 Jun 2023 19:14:26 +0200	[thread overview]
Message-ID: <7e7f3d22-c055-cb2d-7092-3ca4475a38cd@proxmox.com> (raw)
In-Reply-To: <20230417070418.134721-1-f.gruenbichler@proxmox.com>

Am 17/04/2023 um 09:04 schrieb Fabian Grünbichler:
> it causes severe slow downs on fast disks, and we still have other rsyncable
> compressors available.
> 
> it was originally added based on wrong documentation that made the performance
> impact look a lot smaller than it actually is.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> 
> Notes:
>     IMHO, we can always re-introduce it as configurable opt-in option if somebody
>     really needs this combination.. and most things for which you might want
>     rsyncable are better off just using PBS nowadays anyway.
> 
>  PVE/VZDump.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!




      reply	other threads:[~2023-06-06 17:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-17  7:04 [pve-devel] " Fabian Grünbichler
2023-06-06 17:14 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e7f3d22-c055-cb2d-7092-3ca4475a38cd@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal