From: Filip Schauer <f.schauer@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH v3 storage] fix #5191: api, cli: implement moving a volume between storages
Date: Wed, 18 Sep 2024 16:56:21 +0200 [thread overview]
Message-ID: <7e2e502e-355d-44ff-844c-fb3f9cda906c@proxmox.com> (raw)
In-Reply-To: <276d995f-00ed-46c9-9e1b-deff755fcb5d@proxmox.com>
On 05/09/2024 14:12, Fiona Ebner wrote:
>> @@ -483,15 +485,173 @@ __PACKAGE__->register_method ({
>> return $upid;
>> }});
>>
>> +sub volume_move {
> Should this even be a new top-level method? Or can/should we extend
> export/import instead, to not only cover guest images? Because with this
> top-level method we block the way for external storage plugins to
> support this functionality too if they don't adhere to our assumptions.
We do not use the existing export/import because we want to use `move`
instead of copying when `--delete` is passed. This improves performance
when moving between storages on the same storage backend.
Other than that the feedback was incorporated in patch v4:
https://lists.proxmox.com/pipermail/pve-devel/2024-September/065380.html
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-09-18 14:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 12:59 Filip Schauer
2024-09-05 12:12 ` Fiona Ebner
2024-09-18 14:56 ` Filip Schauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e2e502e-355d-44ff-844c-fb3f9cda906c@proxmox.com \
--to=f.schauer@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox