* [pve-devel] [PATCH manager] ui: dc: subscription: fix subscription check
@ 2022-10-19 10:00 Aaron Lauterer
2022-10-19 10:15 ` Dominik Csapak
0 siblings, 1 reply; 2+ messages in thread
From: Aaron Lauterer @ 2022-10-19 10:00 UTC (permalink / raw)
To: pve-devel
With the change to the rust backend for the subscription check, the
return value changed as well.
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
This is the simple fix. We could also change it to lower case first, if
we expect that this might change again.
I don't think that PMG is affected by this, am not 100% sure.
www/manager6/dc/Support.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/dc/Support.js b/www/manager6/dc/Support.js
index 1b51e5ba..b8e9b2ff 100644
--- a/www/manager6/dc/Support.js
+++ b/www/manager6/dc/Support.js
@@ -61,7 +61,7 @@ Ext.define('PVE.dc.Support', {
},
success: function(response, opts) {
let data = response.result.data;
- if (data.status === 'Active') {
+ if (data.status === 'active') {
if (data.level === 'c') {
me.updateCommunity(data);
} else {
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [pve-devel] [PATCH manager] ui: dc: subscription: fix subscription check
2022-10-19 10:00 [pve-devel] [PATCH manager] ui: dc: subscription: fix subscription check Aaron Lauterer
@ 2022-10-19 10:15 ` Dominik Csapak
0 siblings, 0 replies; 2+ messages in thread
From: Dominik Csapak @ 2022-10-19 10:15 UTC (permalink / raw)
To: pve-devel
On 10/19/22 12:00, Aaron Lauterer wrote:
> With the change to the rust backend for the subscription check, the
> return value changed as well.
>
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> This is the simple fix. We could also change it to lower case first, if
> we expect that this might change again.
>
> I don't think that PMG is affected by this, am not 100% sure.
>
> www/manager6/dc/Support.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/manager6/dc/Support.js b/www/manager6/dc/Support.js
> index 1b51e5ba..b8e9b2ff 100644
> --- a/www/manager6/dc/Support.js
> +++ b/www/manager6/dc/Support.js
> @@ -61,7 +61,7 @@ Ext.define('PVE.dc.Support', {
> },
> success: function(response, opts) {
> let data = response.result.data;
> - if (data.status === 'Active') {
> + if (data.status === 'active') {
> if (data.level === 'c') {
> me.updateCommunity(data);
> } else {
i'd rather fix it like we did the other places:
data.status.toLowerCase() === 'active'
to check both variants
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-19 10:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-19 10:00 [pve-devel] [PATCH manager] ui: dc: subscription: fix subscription check Aaron Lauterer
2022-10-19 10:15 ` Dominik Csapak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox