From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH manager] ui: dc: subscription: fix subscription check
Date: Wed, 19 Oct 2022 12:15:54 +0200 [thread overview]
Message-ID: <7e297066-5bb5-fb29-3ddf-a3a12733cc45@proxmox.com> (raw)
In-Reply-To: <20221019100036.364733-1-a.lauterer@proxmox.com>
On 10/19/22 12:00, Aaron Lauterer wrote:
> With the change to the rust backend for the subscription check, the
> return value changed as well.
>
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> This is the simple fix. We could also change it to lower case first, if
> we expect that this might change again.
>
> I don't think that PMG is affected by this, am not 100% sure.
>
> www/manager6/dc/Support.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/manager6/dc/Support.js b/www/manager6/dc/Support.js
> index 1b51e5ba..b8e9b2ff 100644
> --- a/www/manager6/dc/Support.js
> +++ b/www/manager6/dc/Support.js
> @@ -61,7 +61,7 @@ Ext.define('PVE.dc.Support', {
> },
> success: function(response, opts) {
> let data = response.result.data;
> - if (data.status === 'Active') {
> + if (data.status === 'active') {
> if (data.level === 'c') {
> me.updateCommunity(data);
> } else {
i'd rather fix it like we did the other places:
data.status.toLowerCase() === 'active'
to check both variants
prev parent reply other threads:[~2022-10-19 10:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 10:00 Aaron Lauterer
2022-10-19 10:15 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e297066-5bb5-fb29-3ddf-a3a12733cc45@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox