From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Daniel Herzig <d.herzig@proxmox.com>
Subject: [pve-devel] applied: [PATCH widget-toolkit v2] node/ServiceView: fix #5611: hiding the non-installed services
Date: Mon, 11 Nov 2024 21:30:31 +0100 [thread overview]
Message-ID: <7e04770a-d37c-4151-87c3-5aeea1436275@proxmox.com> (raw)
In-Reply-To: <20241111075811.5008-1-d.herzig@proxmox.com>
Am 11.11.24 um 08:58 schrieb Daniel Herzig:
> This patch adds a filter to identify services, which are reported as
> 'not-found' by the api. By default they will not be shown in the UI
> anymore, but visibility can still be toggled using a new checkbox.
>
> Signed-off-by: Daniel Herzig <d.herzig@proxmox.com>
> ---
> changes since v1:
> * applied Thomas' suggestions:
> ** use camelCase for filtername.
> ** invert default preselection logic and corresponding UI labelling.
>
> src/node/ServiceView.js | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
>
applied with slight restructuring of the commit message's subject to
better follow our commit style (or what it should be), thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-11-11 20:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 7:58 [pve-devel] " Daniel Herzig
2024-11-11 20:30 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e04770a-d37c-4151-87c3-5aeea1436275@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.herzig@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox