From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Alexandre Derumier <alexandre.derumier@groupe-cyllene.com>,
pve-devel@lists.proxmox.com
Subject: [pve-devel] applied: [PATCH v2 pve-network] fix #5364: bgp|evpn: derivated router-id from mac address for ipv6 underlay
Date: Mon, 22 Apr 2024 14:03:03 +0200 [thread overview]
Message-ID: <7df6d252-af15-43ee-893e-db890dbdc8d1@proxmox.com> (raw)
In-Reply-To: <20240412125742.69845-1-alexandre.derumier@groupe-cyllene.com>
Am 12/04/2024 um 14:57 schrieb Alexandre Derumier:
> for ipv4, we use the iface ipv4 router-id as router-id need to 32bit.
>
> That's doesn't work for pure ipv6 underlay network.
>
> since https://www.rfc-editor.org/rfc/rfc6286, we can use any 32bit id,
> it's just need to be unique in the ASN.
>
> Simply use the last 4 bytes of iface mac address as unique id
>
>
> changelog V2: add missing test
>
> Signed-off-by: Alexandre Derumier <alexandre.derumier@groupe-cyllene.com>
> ---
> src/PVE/Network/SDN/Controllers/BgpPlugin.pm | 3 +-
> src/PVE/Network/SDN/Controllers/EvpnPlugin.pm | 7 ++-
> src/PVE/Network/SDN/Controllers/Plugin.pm | 21 +++++++++
> src/test/run_test_zones.pl | 8 ++++
> .../ipv6underlay/expected_controller_config | 45 +++++++++++++++++++
> .../evpn/ipv6underlay/expected_sdn_interfaces | 42 +++++++++++++++++
> src/test/zones/evpn/ipv6underlay/interfaces | 7 +++
> src/test/zones/evpn/ipv6underlay/sdn_config | 27 +++++++++++
> 8 files changed, 157 insertions(+), 3 deletions(-)
> create mode 100644 src/test/zones/evpn/ipv6underlay/expected_controller_config
> create mode 100644 src/test/zones/evpn/ipv6underlay/expected_sdn_interfaces
> create mode 100644 src/test/zones/evpn/ipv6underlay/interfaces
> create mode 100644 src/test/zones/evpn/ipv6underlay/sdn_config
>
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
parent reply other threads:[~2024-04-22 12:03 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20240412125742.69845-1-alexandre.derumier@groupe-cyllene.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7df6d252-af15-43ee-893e-db890dbdc8d1@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=alexandre.derumier@groupe-cyllene.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox