From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Dominic Jäger" <d.jaeger@proxmox.com>
Subject: Re: [pve-devel] [PATCH widget-toolkit v2 1/3] EditWindow: Change url to 'importdisk' for import
Date: Thu, 20 Aug 2020 17:36:52 +0200 [thread overview]
Message-ID: <7d766efe-9cf4-fe60-a522-c223600cdd6d@proxmox.com> (raw)
In-Reply-To: <20200730101829.52823-2-d.jaeger@proxmox.com>
On 30.07.20 12:18, Dominic Jäger wrote:
> Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
> ---
> v1->v2: unchanged
>
> src/window/Edit.js | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/window/Edit.js b/src/window/Edit.js
> index d7972b6..2dfab19 100644
> --- a/src/window/Edit.js
> +++ b/src/window/Edit.js
> @@ -134,6 +134,10 @@ Ext.define('Proxmox.window.Edit', {
> values = undefined;
> }
>
> + if (me.isImport) {
> + url = url.replace('config', 'importdisk');
> + }
> +
I'd rather avoid doing this here, i.e., the common shared code should not
do such transforming things specific for a single use case downstream..
That adds coupling, which should be avoided if possible.
Why can the import window instance not handle this?
sorry to catch this only now..
next prev parent reply other threads:[~2020-08-20 15:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 10:18 [pve-devel] [PATCH widget-toolkit v2 0/3] Add GUI for importdisk Dominic Jäger
2020-07-30 10:18 ` [pve-devel] [PATCH widget-toolkit v2 1/3] EditWindow: Change url to 'importdisk' for import Dominic Jäger
2020-08-20 15:36 ` Thomas Lamprecht [this message]
2020-08-24 8:42 ` Dominic Jäger
2020-08-25 9:31 ` Dominic Jäger
2020-07-30 10:18 ` [pve-devel] [PATCH manager v2 2/3] Hardware View: Add GUI for importdisk Dominic Jäger
2020-07-30 10:18 ` [pve-devel] [PATCH qemu-server v2 3/3] Move importdisk from qm to API Dominic Jäger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d766efe-9cf4-fe60-a522-c223600cdd6d@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.jaeger@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox