public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Michael Köppl" <m.koeppl@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Daniel Kral <d.kral@proxmox.com>
Subject: Re: [pve-devel] [PATCH docs 1/5] ha: affinity rules: simplify overly verbose rule conflicts and errors section
Date: Tue, 5 Aug 2025 09:47:59 +0200	[thread overview]
Message-ID: <7d367251-1610-46aa-8161-bb3cac950b9c@proxmox.com> (raw)
In-Reply-To: <20250804141204.207216-1-d.kral@proxmox.com>

Apart from a typo I noted on 5/5 and the comments already made by
Hannes, I did not notice any errors and the changes improve the
comprehensibility of the docs IMO, so consider these changes:

Reviewed-by: Michael Köppl <m.koeppl@proxmox.com>

On 8/4/25 16:12, Daniel Kral wrote:
> Suggested-by: Hannes Dürr <h.duerr@proxmox.com>
> Signed-off-by: Daniel Kral <d.kral@proxmox.com>
> ---
> I only included some of the suggestions for the rule conflicts & errors
> part from Hannes for now as these are more important to be correct and
> understandable for the release.
> 
>  ha-manager.adoc | 29 ++++++++++-------------------
>  1 file changed, 10 insertions(+), 19 deletions(-)
> 
> diff --git a/ha-manager.adoc b/ha-manager.adoc
> index 77d7a65..d6ac75d 100644
> --- a/ha-manager.adoc
> +++ b/ha-manager.adoc
> @@ -849,34 +849,25 @@ Rule Conflicts and Errors
>  HA rules can impose rather complex constraints on the HA resources. To ensure
>  that a new or modified HA rule does not introduce uncertainty into the HA
>  stack's CRS scheduler, HA rules are tested for feasibility before these are
> -applied. If a rule does fail any of these tests, the rule is disabled until the
> -conflicts and errors is resolved.
> +applied. For any rules that fail these tests, these rules are disabled until
> +the conflicts and errors have been resolved.
>  
>  Currently, HA rules are checked for the following feasibility tests:
>  
> -* A HA resource can only be referenced by a single HA node affinity rule in
> -  total. If two or more HA node affinity rules specify the same HA resource,
> -  these HA node affinity rules will be disabled.
> +* An HA resource can only be part of a single HA node affinity rule.
>  
> -* A HA resource affinity rule must specify at least two HA resources to be
> -  feasible. If a HA resource affinity rule specifies only one HA resource, the
> -  HA resource affinity rule will be disabled.
> +* An HA resource affinity rule must have at least two HA resources.
>  
> -* A HA resource affinity rule must specify no more HA resources than there are
> -  nodes in the cluster. If a HA resource affinity rule specifies more HA
> -  resources than there are in the cluster, the HA resource affinity rule will
> -  be disabled.
> +* A negative HA resource affinity rule cannot specify more HA resources than
> +  there are nodes in the cluster. Otherwise, the HA resources do not have
> +  enough nodes to be separated.
>  
>  * A positive HA resource affinity rule cannot specify the same two or more HA
>    resources as a negative HA resources affinity rule. That is, two or more HA
> -  resources cannot be kept together and separate at the same time. If any pair
> -  of positive and negative HA resource affinity rules do specify the same two
> -  or more HA resources, both HA resource affinity rules will be disabled.
> +  resources cannot be kept together and separate at the same time.
>  
> -* A HA resource can only be referenced by either a HA node affinity rule or HA
> -  resource affinity rules, but not both at the same time. If there is at least
> -  one HA node affinity rule and at least one HA resource affinity rule, which
> -  specify the same HA resource, these rules will be disabled.
> +* A HA resource can only be part of either a HA node affinity rule or HA
> +  resource affinity rules, but not both at the same time.
>  
>  [[ha_manager_fencing]]
>  Fencing



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

  parent reply	other threads:[~2025-08-05  7:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-04 14:11 Daniel Kral
2025-08-04 14:11 ` [pve-devel] [PATCH docs 2/5] ha: rules: update about mixed usage of node and resource affinity rules Daniel Kral
2025-08-04 15:09   ` Hannes Duerr
2025-08-05  7:15     ` Daniel Kral
2025-08-04 14:11 ` [pve-devel] [PATCH docs 3/5] ha: rules: document crs behavior for split positive resource affinity Daniel Kral
2025-08-05  7:42   ` Michael Köppl
2025-08-05  7:50     ` Daniel Kral
2025-08-04 14:11 ` [pve-devel] [PATCH docs 4/5] ha: mark ha groups as deprecated and note migration to node affinity rules Daniel Kral
2025-08-04 14:11 ` [pve-devel] [PATCH docs 5/5] ha: replace in-text references to ha groups with ha rules Daniel Kral
2025-08-04 15:24   ` Hannes Duerr
2025-08-05  7:39     ` Daniel Kral
2025-08-05  7:41   ` Michael Köppl
2025-08-05  7:47 ` Michael Köppl [this message]
2025-08-05  8:01 ` [pve-devel] applied: [PATCH docs 1/5] ha: affinity rules: simplify overly verbose rule conflicts and errors section Daniel Kral

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7d367251-1610-46aa-8161-bb3cac950b9c@proxmox.com \
    --to=m.koeppl@proxmox.com \
    --cc=d.kral@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal