public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>
To: "t.lamprecht@proxmox.com" <t.lamprecht@proxmox.com>,
	"pve-devel@pve.proxmox.com" <pve-devel@pve.proxmox.com>
Subject: Re: [pve-devel] pve-network : downgrading frr dependency to suggested
Date: Mon, 20 Nov 2023 17:20:03 +0000	[thread overview]
Message-ID: <7cce062d7d30216f474b12b3a7fae826c940c43e.camel@groupe-cyllene.com> (raw)
In-Reply-To: <ad3fc909-daa5-4518-a6fb-32addb617031@proxmox.com>

-------- Message initial --------
De: Thomas Lamprecht <t.lamprecht@proxmox.com>
À: PVE development discussion <pve-devel@pve.proxmox.com>, Alexandre
Derumier <Alexandre.DERUMIER@groupe-cyllene.com>
Objet: pve-network : downgrading frr dependency to suggested
Date: 20/11/2023 17:55:40

>>Hi,

>>I'd downgrade frr-pythontools to a suggestion, as Debian has install-
>>recommends
>>on by default, so an upgrade would pull FRR always in, if we add a
>>dependency
>>for our SDN package to e.g. pve-manager, and FRR daemon is quite
noisy >>IIRC.

>>Would that be fine for you? A short documentation how to install it,
or >>dnsmasq
>>for getting the DHCP feature, could be added.


It's needed for transparent reload (usr/lib/frr/frr-reload.py).

so you can be 100% sure It'll break if it's not installed ^_^



>>For the code it would be nice to add a helper that asserts that frr
>>is installed
>>for all API endpoints that need it, that way user get informed
>>upfront, similar
>>to how we do it for ceph (but no full web installer for now ^^)

Yes good idea. 

I don't known if it's easy to check, as the frr is local to each node,
and the sdn api is global at datacenter level. ?






  reply	other threads:[~2023-11-20 17:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-20 16:55 Thomas Lamprecht
2023-11-20 17:20 ` DERUMIER, Alexandre [this message]
2023-11-20 17:34   ` Thomas Lamprecht
2023-11-21  8:54     ` DERUMIER, Alexandre
2023-11-21 10:50       ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7cce062d7d30216f474b12b3a7fae826c940c43e.camel@groupe-cyllene.com \
    --to=alexandre.derumier@groupe-cyllene.com \
    --cc=pve-devel@pve.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal