From: Stefan Hanreich <s.hanreich@proxmox.com>
To: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>,
"pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>
Cc: "me@nurohman.com" <me@nurohman.com>
Subject: Re: [pve-devel] [PATCH pve-network] Fix #5496: NetBox add ip range
Date: Thu, 12 Dec 2024 14:17:46 +0100 [thread overview]
Message-ID: <7cca7a4c-0b7e-4555-8941-64f8d5ca74c6@proxmox.com> (raw)
In-Reply-To: <b6d41bd46ba97b50da21589f2ea676ab34cac339.camel@groupe-cyllene.com>
On 12/12/24 08:20, DERUMIER, Alexandre wrote:
> but shouldn't theses ranges be added when the dhcp ranges are submitted
> on subnet create/update api call ? (I'm not 100% sure, but I think it
> was missing a hook to call the sdn api when submitting the dhcp ranges
> )
Yes, I also think this should be handled in the create / update call
rather than doing it when trying to allocate the IP.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-12-12 13:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 23:38 nurohman via pve-devel
2024-12-12 7:20 ` DERUMIER, Alexandre via pve-devel
2024-12-13 9:55 ` Lou Lecrivain via pve-devel
[not found] ` <b6d41bd46ba97b50da21589f2ea676ab34cac339.camel@groupe-cyllene.com>
2024-12-12 13:17 ` Stefan Hanreich [this message]
[not found] <20241211233832.806187-1-me@nurohman.com>
2024-12-12 13:20 ` Stefan Hanreich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cca7a4c-0b7e-4555-8941-64f8d5ca74c6@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=alexandre.derumier@groupe-cyllene.com \
--cc=me@nurohman.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox