From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH installer 3/3] auto-installer: raise minimum root password length to 8 characters
Date: Mon, 7 Oct 2024 11:49:02 +0200 [thread overview]
Message-ID: <7cb448b4-a68a-41ea-b874-5bc1bff97140@proxmox.com> (raw)
In-Reply-To: <20241007092218.723938-4-c.heiss@proxmox.com>
On 10/7/24 11:22, Christoph Heiss wrote:
> .. in accordance with current NIST recommendations [0].
>
> It's 2024; so reasonable to expect an 8-character-password at the
> minimum.
>
> [0] https://pages.nist.gov/800-63-4/sp800-63b.html#passwordver
>
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> proxmox-auto-installer/src/utils.rs | 5 +++++
> .../tests/resources/parse_answer/disk_match.json | 2 +-
> .../tests/resources/parse_answer/disk_match.toml | 2 +-
> .../tests/resources/parse_answer/disk_match_all.json | 2 +-
> .../tests/resources/parse_answer/disk_match_all.toml | 2 +-
> .../tests/resources/parse_answer/disk_match_any.json | 2 +-
> .../tests/resources/parse_answer/disk_match_any.toml | 2 +-
> .../tests/resources/parse_answer/minimal.json | 2 +-
> .../tests/resources/parse_answer/minimal.toml | 2 +-
> .../tests/resources/parse_answer/nic_matching.json | 2 +-
> .../tests/resources/parse_answer/nic_matching.toml | 2 +-
> .../tests/resources/parse_answer/specific_nic.json | 2 +-
> .../tests/resources/parse_answer/specific_nic.toml | 2 +-
> proxmox-auto-installer/tests/resources/parse_answer/zfs.json | 2 +-
> proxmox-auto-installer/tests/resources/parse_answer/zfs.toml | 2 +-
> 15 files changed, 19 insertions(+), 14 deletions(-)
>
> diff --git a/proxmox-auto-installer/src/utils.rs b/proxmox-auto-installer/src/utils.rs
> index 45ad222..e0dd2ae 100644
> --- a/proxmox-auto-installer/src/utils.rs
> +++ b/proxmox-auto-installer/src/utils.rs
> @@ -13,6 +13,7 @@ use proxmox_installer_common::{
> setup::{
> InstallConfig, InstallRootPassword, InstallZfsOption, LocaleInfo, RuntimeInfo, SetupInfo,
> },
> + ROOT_PASSWORD_MIN_LENGTH,
> };
> use serde::{Deserialize, Serialize};
>
> @@ -309,6 +310,10 @@ fn verify_root_password_settings(answer: &Answer) -> Result<()> {
> } else if answer.global.root_password.is_none() && answer.global.root_password_hashed.is_none()
> {
> bail!("One of `global.root_password` or `global.root_password_hashed` must be set");
> + } else if answer.global.root_password.is_some()
> + && answer.global.root_password.as_ref().map(|s| s.len()) < Some(ROOT_PASSWORD_MIN_LENGTH)
> + {
> + bail!("`global.root_password` must be at least {ROOT_PASSWORD_MIN_LENGTH} characters long");
> } else {
> Ok(())
> }
maybe match is better at this point?
Something like
match (answer.global.root_password, answer.global.root_password_hashed) {
[..]
(Some(password), _) if password.len() < ROOT_PASSWORD_MIN_LENGTH,
[..]
}
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-10-07 9:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 9:22 [pve-devel] [PATCH installer 0/3] " Christoph Heiss
2024-10-07 9:22 ` [pve-devel] [PATCH installer 1/3] proxinstall: " Christoph Heiss
2024-10-07 9:22 ` [pve-devel] [PATCH installer 2/3] tui: " Christoph Heiss
2024-10-07 9:22 ` [pve-devel] [PATCH installer 3/3] auto-installer: " Christoph Heiss
2024-10-07 9:49 ` Stefan Hanreich [this message]
2024-10-07 9:52 ` Christoph Heiss
2024-10-07 9:55 ` Stefan Hanreich
2024-10-07 10:02 ` Christoph Heiss
2024-10-07 10:39 ` Stefan Hanreich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cb448b4-a68a-41ea-b874-5bc1bff97140@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox