From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Matthias Heiserer <m.heiserer@proxmox.com>
Subject: Re: [pve-devel] [PATCH widget-toolkit 2/2] use the width-helper from utils
Date: Fri, 25 Mar 2022 09:37:06 +0100 [thread overview]
Message-ID: <7c49c1a0-b1ea-0595-6d97-bdb53571ecc0@proxmox.com> (raw)
In-Reply-To: <20220324113331.681971-2-m.heiserer@proxmox.com>
please add a prefixing tag to the comment subject:
apt repos: use new button max-width helper from utils
On 24.03.22 12:33, Matthias Heiserer wrote:
> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
> ---
> src/node/APTRepositories.js | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js
> index 09ed0be..d63a569 100644
> --- a/src/node/APTRepositories.js
> +++ b/src/node/APTRepositories.js
> @@ -230,16 +230,7 @@ Ext.define('Proxmox.node.APTRepositoriesGrid', {
> });
> },
> listeners: {
> - render: function(btn) {
> - // HACK: calculate the max button width on first render to avoid toolbar glitches
> - let defSize = btn.getSize().width;
> -
> - btn.setText(btn.altText);
> - let altSize = btn.getSize().width;
> -
> - btn.setText(btn.defaultText);
> - btn.setSize({ width: altSize > defSize ? altSize : defSize });
> - },
> + render: Proxmox.Utils.calculateWidth,
> },
> },
> ],
next prev parent reply other threads:[~2022-03-25 8:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 11:33 [pve-devel] [PATCH widget-toolkit 1/2] Utils: add calculate max button width hack Matthias Heiserer
2022-03-24 11:33 ` [pve-devel] [PATCH widget-toolkit 2/2] use the width-helper from utils Matthias Heiserer
2022-03-25 8:37 ` Thomas Lamprecht [this message]
2022-03-24 11:33 ` [pve-devel] [PATCH manager] " Matthias Heiserer
2022-03-25 8:47 ` Thomas Lamprecht
2022-03-25 8:35 ` [pve-devel] [PATCH widget-toolkit 1/2] Utils: add calculate max button width hack Thomas Lamprecht
2022-03-25 8:47 ` Thomas Lamprecht
2022-03-28 9:43 ` Matthias Heiserer
2022-03-28 9:44 ` Thomas Lamprecht
2022-03-28 10:17 ` Matthias Heiserer
2022-03-28 10:27 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c49c1a0-b1ea-0595-6d97-bdb53571ecc0@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.heiserer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox