Re: [pve-devel] [PATCH v2 manager 2/2] close #3476: vzdump: add job-init hook

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

On 17.01.22 16:37, Fabian Grünbichler wrote:
> On January 17, 2022 12:35 pm, Fabian Ebner wrote:
>> which allows users to prepare the backup storage for activation (e.g.
>> by waking up a remote node).
>>
>> Suggested-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
>> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> 
> Reviewed-by: Fabian Grünbichler <f.gruenbichler@proxmox.com> 
> 
> but giving others a chance to object to the new phase before applying ;)

For the general approach of adding this hook

Acked-by: Thomas Lamprecht <t.lamprecht@proxmox.com>


>> @@ -26,6 +28,14 @@ if ($phase eq 'job-start' ||
>>      print "storeid=$storeid;" if defined($storeid);
>>      print "\n";
>>  
>> +    # example: wake up remote storage node and enable storage
>> +    if ($phase eq 'job-init') {
>> +        #system ("") == 0 ||

nit: maybe add a command there so that it's easier to adapt for non-perl people, whom
may not know that above is not some required magic incantation that they must keep as
is. So, e.g.:

#system("wakeonlan AA:BB:CC:DD:EE:FF")
#sleep(30);

but as said, just a nit that caught my eyes, no hard feelings on that whatsoever.