From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] ui: fix usage of findRecord
Date: Thu, 26 Nov 2020 10:59:49 +0100 [thread overview]
Message-ID: <7bc5b302-901b-b30b-3806-3b9558f82fcc@proxmox.com> (raw)
In-Reply-To: <20201126081953.25954-1-d.csapak@proxmox.com>
On 26.11.20 09:19, Dominik Csapak wrote:
> findRecord does not match exactly, but only at the beginning and
> case insensitive, by default. Change all calls to be case sensitive
> and an exactmatch (we never want the default behaviour afaics).
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/manager6/dc/Backup.js | 4 ++--
> www/manager6/dc/SecurityGroups.js | 2 +-
> www/manager6/form/ACMEAPISelector.js | 2 +-
> www/manager6/form/NodeSelector.js | 2 +-
> www/manager6/form/VMCPUFlagSelector.js | 2 +-
> www/manager6/form/ViewSelector.js | 2 +-
> www/manager6/grid/BackupView.js | 6 ++++--
> www/manager6/grid/FirewallAliases.js | 2 +-
> www/manager6/panel/IPSet.js | 2 +-
> www/manager6/window/Backup.js | 2 +-
> 10 files changed, 14 insertions(+), 12 deletions(-)
>
>
applied, thanks! as talked off-list, I would find it more ergonomic to add a
"findExactRecord" which combines the advantages of the existing findExact and
findRecord methods.
https://docs.sencha.com/extjs/6.0.1/classic/src/AbstractStore.js.html#line341
prev parent reply other threads:[~2020-11-26 10:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 8:19 [pve-devel] " Dominik Csapak
2020-11-26 9:59 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bc5b302-901b-b30b-3806-3b9558f82fcc@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox