From: Matthias Heiserer <m.heiserer@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Daniel Bowder <daniel@bowdernet.com>
Subject: Re: [pve-devel] [PATCH 0/5] fix #3593: Added vm core pinning
Date: Wed, 8 Jun 2022 15:00:38 +0200 [thread overview]
Message-ID: <7b52e845-3bc7-01b3-6882-358739a6d5b9@proxmox.com> (raw)
In-Reply-To: <20220608115428.250668-1-daniel@bowdernet.com>
On 08.06.2022 13:54, Daniel Bowder wrote:
> These five patches add the ability to pin a QEMU VMs processes to a defined set of CPU cores. The changes required spanned multiple repos and have all been included in these five patches. The patches add "cpuset" as an option in the qm configuration file and enable the editing of this parameter via the gui.
>
Thank you for your patches!
Regarding the formatting: Please make sure to follow our Perl and
Javascript style guides [0][1] and the Developer Documentation [2]. All
your patches use a nonconformant indentation :/
Also, the repository (e.g. qemu-server) should be part of the prefix,
next to "PATCH", this makes it easier to parse where they belong.
In case you haven't done so yet, we require a CLA (explained in [2])
from you in order to use your code.
[0] https://pve.proxmox.com/wiki/Perl_Style_Guide
[1] https://pve.proxmox.com/wiki/Javascript_Style_Guide
[2] https://pve.proxmox.com/wiki/Developer_Documentation
next prev parent reply other threads:[~2022-06-08 13:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 11:54 Daniel Bowder
2022-06-08 11:54 ` [pve-devel] [PATCH 1/5] fix #3593: Added vm core pinning pve-docs Daniel Bowder
2022-06-08 14:20 ` Matthias Heiserer
2022-06-08 11:54 ` [pve-devel] [PATCH 2/5] fix #3593: Added vm core pinning pve-guest-common Daniel Bowder
2022-06-08 11:54 ` [pve-devel] [PATCH 3/5] fix #3593: Added vm core pinning qemu-server Daniel Bowder
2022-06-08 14:45 ` Matthias Heiserer
2022-06-08 11:54 ` [pve-devel] [PATCH 4/5] fix #3593: Added vm core pinning proxmox-widget-toolkit Daniel Bowder
2022-06-08 11:54 ` [pve-devel] [PATCH 5/5] fix #3593: Added vm core pinning pve-manager Daniel Bowder
2022-06-08 14:39 ` Matthias Heiserer
2022-06-08 13:00 ` Matthias Heiserer [this message]
2022-06-08 13:21 ` [pve-devel] [PATCH 0/5] fix #3593: Added vm core pinning Daniel Bowder
2022-06-08 13:32 ` Matthias Heiserer
2022-06-08 13:43 ` Daniel Bowder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b52e845-3bc7-01b3-6882-358739a6d5b9@proxmox.com \
--to=m.heiserer@proxmox.com \
--cc=daniel@bowdernet.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox