From: Stefan Hanreich <s.hanreich@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Jillian Morgan <jillian.morgan@primordial.ca>
Subject: Re: [pve-devel] [PATCH close #545, #5203: Allow bridges to have any valid interface name 1/2]
Date: Wed, 21 Feb 2024 15:13:48 +0100 [thread overview]
Message-ID: <7b20a7f1-48a1-4ac4-bb53-ba6a4ba8dff0@proxmox.com> (raw)
In-Reply-To: <20240126171741.2251760-2-jillian.morgan@primordial.ca>
On 1/26/24 18:17, Jillian Morgan wrote:
> Allow bridges to have any valid interface name
> Repo: proxmox-widget-toolkit
>
> Allow the web UI to accept bridge interfaces with any valid interface name,
> rather than being limited to the arbitrary "vmbr" prefix.
>
> Signed-off-by: Jillian Morgan <jillian.morgan@primordial.ca>
> ---
> proxmox-widget-toolkit/src/Toolkit.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/Toolkit.js b/src/Toolkit.js
> index 6fd73f5..3a03f55 100644
> --- a/src/Toolkit.js
> +++ b/src/Toolkit.js
> @@ -76,7 +76,7 @@ Ext.apply(Ext.form.field.VTypes, {
> MacPrefixText: gettext('Example') + ': 02:8f - ' + gettext('only unicast addresses are allowed'),
>
> BridgeName: function(v) {
> - return (/^vmbr\d{1,4}$/).test(v);
> + return (/^[a-z][a-z0-9_]{1,20}$/).test(v);
character limit for interfaces is 15 characters (excluding null
terminator), so we should set the regex accordingly
> },
> VlanName: function(v) {
> if (Proxmox.Utils.VlanInterface_match.test(v)) {
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
next prev parent reply other threads:[~2024-02-21 14:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 17:17 [pve-devel] [PATCH close #545, #5203: Allow bridges to have any valid interface name 0/2] Jillian Morgan
2024-01-26 17:17 ` [pve-devel] [PATCH close #545, #5203: Allow bridges to have any valid interface name 1/2] Jillian Morgan
2024-02-21 14:13 ` Stefan Hanreich [this message]
2024-01-26 17:17 ` [pve-devel] [PATCH close #545, #5203: Allow bridges to have any valid interface name 2/2] Jillian Morgan
2024-02-21 14:14 ` Stefan Hanreich
2024-02-21 14:23 ` Stefan Hanreich
2024-02-21 14:21 ` [pve-devel] [PATCH close #545, #5203: Allow bridges to have any valid interface name 0/2] Stefan Hanreich
[not found] ` <df4fcfca9d62156ff3ea1a8826527a75d2603594.camel@groupe-cyllene.com>
2024-02-22 8:11 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b20a7f1-48a1-4ac4-bb53-ba6a4ba8dff0@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=jillian.morgan@primordial.ca \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox