public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Daniel Kral <d.kral@proxmox.com>
To: Christoph Heiss <c.heiss@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH installer v2] auto: allow a binary executable as the first boot executable
Date: Wed, 18 Dec 2024 08:29:08 +0100	[thread overview]
Message-ID: <7b180c9a-eca6-44ae-97ac-fff8770e4a02@proxmox.com> (raw)
In-Reply-To: <D6AHH8D940P7.3M53T2TUAZGMN@proxmox.com>

On 12/13/24 11:00, Christoph Heiss wrote:
> The "Automated Installation" page needs to be updated though, to
> reflect:
> 
> a) that either shell-scripts or compiled binaries can be used and
> b) that the compiled binaries must be (obviously) x86_64 and best case
>     statically linked, as there otherwise no guarantees that it will run
>     on the target system and might just fail blindly.

Thanks for taking a second look at this! I've added the following to the 
"Automated Installation" page:

```diff
@@ -233,7 +233,7 @@

  === First Boot Hook Section ===

-Optional. It can be used to configure a script to run on the first boot 
of the new system after a successful installation.
+Optional. It can be used to configure a shell script or a compiled 
binary to run on the first boot of the new system after a successful 
installation.

  If configured, this installs an additional package named 
<code>proxmox-first-boot</code>. After booting the new system for the 
first time, this package can safely be removed using <code>apt purge 
proxmox-first-boot</code>.

@@ -250,6 +250,8 @@

  {{Note| The maximum executable file size is 1 MiB, for both 
integrating it into the ISO and fetching it from a URL.}}

+{{Note| Compiled binaries must target x86_64 Linux and should be 
statically linked, as there are no guarantees for libraries installed on 
the first boot.}}
+
  === Answer File Validation ===

  The <code>proxmox-auto-install-assistant</code> tool can also be used 
to validate the syntax of an answer file and display the identifying 
information that will be sent to the HTTP(s) server when fetching the 
answer file.
```

On 12/13/24 11:00, Christoph Heiss wrote:
> FWIW, just thinking out loud here: Maybe the fetching of the first-boot
> hook should be moved into `proxmox-fetch-answer` altogether. In a sense
> that `proxmox-fetch-answer` would fetch all the needed things in
> advance, such that the auto-installer, post-hook etc. doesn't have to do
> that anymore.
> But that's really not pressing of any kind, rather a long-term thing.

Sounds like a good idea! If you've got other things to do, I can take a 
look at this before the next release for sure.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      reply	other threads:[~2024-12-18  7:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-11  9:24 Daniel Kral
2024-12-13 10:00 ` Christoph Heiss
2024-12-18  7:29   ` Daniel Kral [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b180c9a-eca6-44ae-97ac-fff8770e4a02@proxmox.com \
    --to=d.kral@proxmox.com \
    --cc=c.heiss@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal