From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
YU Jincheng <shana@zju.edu.cn>
Subject: [pve-devel] applied: [PATCH v2 acme] Fix EBA MAC key decoding
Date: Mon, 12 Feb 2024 09:54:43 +0100 [thread overview]
Message-ID: <7b0c9626-e57d-4db9-b3b4-5b37825d635e@proxmox.com> (raw)
In-Reply-To: <20240125082800.11857-1-shana@zju.edu.cn>
Am 25/01/2024 um 09:28 schrieb YU Jincheng:
> Accroding to RFC 8555:
>
>> The MAC key SHOULD be provided in base64url-encoded form...
>
> However, currently we are only decoding the MAC key as base64.
> This patch chooses the correct function to decode the user provided
> MAC key. This can fix authentication error when a user uses command
> `pvenode acme account register` and paste the EBA MAC key as prompted.
>
> Signed-off-by: YU Jincheng <shana@zju.edu.cn>
> ---
> src/PVE/ACME.pm | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
>
applied, with Folke's T-b, thanks!
I fixed a small typo in the commit message and while at it I
reworded the commit subject to better fit our style (and to make
it easier to write a debian/changelog entry from this).
prev parent reply other threads:[~2024-02-12 8:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 10:40 [pve-devel] [PATCH " YU Jincheng
2024-01-18 14:28 ` Folke Gleumes
2024-01-25 8:28 ` [pve-devel] [PATCH v2 " YU Jincheng
2024-01-29 13:15 ` Folke Gleumes
2024-02-12 8:54 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b0c9626-e57d-4db9-b3b4-5b37825d635e@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=shana@zju.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox