public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: [pve-devel] applied: [PATCH zfsonlinux] fix #4440: cherry-pick patch for mountpoint=legacy on /
Date: Mon, 2 Jan 2023 17:12:36 +0100	[thread overview]
Message-ID: <7b068614-68f4-bafe-6239-9ab1890b949f@proxmox.com> (raw)
In-Reply-To: <20230102142549.728593-1-s.ivanov@proxmox.com>

Am 02/01/2023 um 15:25 schrieb Stoiko Ivanov:
> As reported having set 'mountpoint=legacy' on the root dataset (for a
> default install this would be 'rpool/ROOT/pve-1') for mounting through
> e.g. /etc/fstab breaks booting in initramfs
> 
> The cherry-picked patch is already applied to zfs-2.1.8-staging
> upstream so will be included in the next zfs point release.
> 
> reproduced the issue on a VM with ZFS on root by:
> * booting into a PVE 7.3 iso (to have zfs and an inactive
>   rpool/ROOT/pve-1)
> * `zpool import -ocachefile=none -N -f rpool
> * `zfs set mountpoint=legacy rpool/ROOT/pve-1`
> * `mount -t zfs rpool/ROOT/pve-1 /mnt
> * `echo "rpool/ROOT/pve-1 / zfs defaults 0 0" >> /mnt/etc/fstab`
> * `zpool export rpool`
> * reboot - the boot breaks with zfs-initramfs 2.1.7-pve1 but works
>   with this patch applied
> 
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> 
> The current changes on zfs-2.1.8-staging could all be applied without too
> much expected fallout (dracut fixes, aarch64 fixes, tests and testconfig)
> If preferred I can send an update of the zfsmodule to the current tip of this
> branch instead
> 

no, works fine as is. I prefer pulling targeted fixes, at least if coming from
a (unreleased) staging branch/version like here.

>  ...itramfs-Fix-legacy-mountpoint-rootfs.patch | 58 +++++++++++++++++++
>  debian/patches/series                         |  1 +
>  2 files changed, 59 insertions(+)
>  create mode 100644 debian/patches/0012-initramfs-Fix-legacy-mountpoint-rootfs.patch
> 
>

applied, thanks!




      reply	other threads:[~2023-01-02 16:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-02 14:25 [pve-devel] " Stoiko Ivanov
2023-01-02 16:12 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b068614-68f4-bafe-6239-9ab1890b949f@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.ivanov@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal