From: Dominik Csapak <d.csapak@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH widget-toolkit v3 1/1] window/FileBrowser: enable tar button by default
Date: Mon, 13 Nov 2023 16:48:16 +0100 [thread overview]
Message-ID: <7ad8ba2d-54bd-4fc6-a830-62427be8bf1d@proxmox.com> (raw)
In-Reply-To: <fb58bfd8-3028-414c-9716-acc9d07da5e5@proxmox.com>
On 11/13/23 16:46, Thomas Lamprecht wrote:
> Am 19/10/2023 um 11:13 schrieb Dominik Csapak:
>> diff --git a/src/window/FileBrowser.js b/src/window/FileBrowser.js
>> index 4e4c639..e036d9f 100644
>> --- a/src/window/FileBrowser.js
>> +++ b/src/window/FileBrowser.js
>> @@ -61,10 +61,6 @@ Ext.define("Proxmox.window.FileBrowser", {
>> 'd': true, // directories
>> },
>>
>> - // enable tar download, this will add a menu to the "Download" button when the selection
>> - // can be downloaded as `.tar` files
>> - enableTar: false,
>> -
>
> ps. isn't there a call-site where we had this set, i.e., that could be dropped now?
>
yes, but that's in proxmox-backup, should i already send that patch
or do we wait until we bump widget-toolkit?
prev parent reply other threads:[~2023-11-13 15:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 9:13 [pve-devel] [PATCH common/storage/widget-toolkit v3] add tar.zst download in pve Dominik Csapak
2023-10-19 9:13 ` [pve-devel] [PATCH common v3 1/1] PBSClient: add 'tar' parameter to file_restore_extract Dominik Csapak
2023-11-06 17:34 ` [pve-devel] applied: " Thomas Lamprecht
2023-10-19 9:13 ` [pve-devel] [PATCH storage v3 1/1] api/filerestore: add 'tar' parameter to 'download' api Dominik Csapak
2023-11-13 15:45 ` [pve-devel] applied: " Thomas Lamprecht
2023-10-19 9:13 ` [pve-devel] [PATCH widget-toolkit v3 1/1] window/FileBrowser: enable tar button by default Dominik Csapak
2023-11-13 15:46 ` [pve-devel] applied: " Thomas Lamprecht
2023-11-13 15:46 ` [pve-devel] " Thomas Lamprecht
2023-11-13 15:48 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ad8ba2d-54bd-4fc6-a830-62427be8bf1d@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox