Re: [pve-devel] [PATCH qemu-server 4/4] api: enable live migration for marked mapped pci devices

[Dominik Csapak <d.csapak@proxmox.com>]

On 3/22/24 14:37, Fiona Ebner wrote:
> Am 18.03.24 um 12:18 schrieb Dominik Csapak:
>> They have to be marked as 'live-migration-capable' in the mapping
>> config, and the driver and qemu must support it.
>>
>> For the gui checks, we now return a list of 'mapped-with-live-migration'
>> entries in the migration preflight api call too.
>>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>>   PVE/API2/Qemu.pm   |  5 +++++
>>   PVE/QemuMigrate.pm | 12 ++++++++----
>>   2 files changed, 13 insertions(+), 4 deletions(-)
>>
>> diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
>> index 4ecaeb91..8581a529 100644
>> --- a/PVE/API2/Qemu.pm
>> +++ b/PVE/API2/Qemu.pm
>> @@ -4453,6 +4453,10 @@ __PACKAGE__->register_method({
>>   		type => 'array',
>>   		description => "List of mapped resources e.g. pci, usb"
>>   	    },
>> +	    'mapped-with-live-migration' => {
>> +		type => 'array',
>> +		description => "List of mapped resources that are marked as capable of live-migration",
>> +	    },
> 
> Should we merge this with 'mapped-resources' for the next major release
> (and add a reminder comment here)? I.e. make that return the objects
> with the additional information.

yeah i thought about that too, i general i'd really like to revampt the
whole api call and it's return values a bit, but that has to wait for
a major release since it will be a breaking change (if we don't want
to duplicate code and keep the old one around...)

i'll add a reminder comment to the api call

> 
>>   	},
>>       },
>>       code => sub {