public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Alexander Zeidler <a.zeidler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 5/7] report: overhaul `dmidecode` related output
Date: Thu, 18 Apr 2024 14:30:05 +0200	[thread overview]
Message-ID: <7ac1a4d627f72be8042ddb16d742aaefbd6c6541.camel@proxmox.com> (raw)
In-Reply-To: <bb31bcf4-75e7-4252-a0a1-4847ec7af7e4@proxmox.com>

On Thu, 2024-04-18 at 12:24 +0200, Mira Limbeck wrote:
> Would it be possible to align these correctly, or just use a single
> space between type and value?

> I'd prefer explicit commands like:

Better formatting can of course be achieved, see the adapted example below, followed by your mentioned `cat` structure.


# cd /sys/devices/virtual/dmi/id; grep -H "" sys_vendor product_name product_version | column -t -s:
sys_vendor       HP
product_name     ProLiant DL380p Gen8
product_version  Not specified

# cd /sys/devices/virtual/dmi/id; grep -H "" board_vendor board_name board_version | column -t -s:
board_vendor   ASUSTeK COMPUTER INC.
board_name     Z13PP-D32 Series
board_version  60SB09M0-SB0G11


# cat /sys/devices/virtual/dmi/id/sys_vendor
HP

# cat /sys/devices/virtual/dmi/id/product_name
ProLiant DL380p Gen8

# cat /sys/devices/virtual/dmi/id/product_version
Not specified

# cat /sys/devices/virtual/dmi/id/board_vendor
ASUSTeK COMPUTER INC.

# cat /sys/devices/virtual/dmi/id/board_name
Z13PP-D32 Series

# cat /sys/devices/virtual/dmi/id/board_version
60SB09M0-SB0G11


> Adding at least one additional newline per file read, but there would be
> no need for cd-ing, printing the filename with grep and trying to align
> the output.

While so far I see no problem with using `cd` or pipes in general, maybe someone else has a strong preference.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2024-04-18 12:30 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-18  9:16 [pve-devel] [PATCH manager 1/7] report: add kernel command line from current boot Alexander Zeidler
2024-04-18  9:16 ` [pve-devel] [PATCH manager 2/7] report: create "jobs" section, add `jobs.cfg` Alexander Zeidler
2024-04-18 20:25   ` [pve-devel] applied: " Thomas Lamprecht
2024-04-18  9:16 ` [pve-devel] [PATCH manager 3/7] report: add `apt-cache policy` to list recognized APT sources Alexander Zeidler
2024-04-18 20:28   ` [pve-devel] applied: " Thomas Lamprecht
2024-04-18  9:16 ` [pve-devel] [PATCH manager 4/7] report: list held back packages Alexander Zeidler
2024-04-18 20:28   ` [pve-devel] applied: " Thomas Lamprecht
2024-04-18  9:16 ` [pve-devel] [PATCH manager 5/7] report: overhaul `dmidecode` related output Alexander Zeidler
2024-04-18 10:24   ` Mira Limbeck
2024-04-18 12:30     ` Alexander Zeidler [this message]
2024-04-18  9:16 ` [pve-devel] [PATCH manager 6/7] report: add info about (un)used memory slots Alexander Zeidler
2024-04-18 10:16   ` Aaron Lauterer
2024-04-18 13:32     ` Alexander Zeidler
2024-04-18 10:20   ` Mira Limbeck
2024-04-18 13:38     ` Alexander Zeidler
2024-04-18  9:16 ` [pve-devel] [PATCH manager 7/7] report: add recent boot timestamps which may show fencing/crash events Alexander Zeidler
2024-04-18 10:43   ` Mira Limbeck
2024-04-18 15:45     ` Alexander Zeidler
2024-04-19  8:56       ` Mira Limbeck
2024-04-18  9:19 ` [pve-devel] [PATCH manager 1/7] report: add kernel command line from current boot Alexander Zeidler
2024-04-18 10:16 ` Aaron Lauterer
2024-04-18 11:05 ` Mira Limbeck
2024-04-18 15:46   ` Alexander Zeidler
2024-04-18 20:25 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ac1a4d627f72be8042ddb16d742aaefbd6c6541.camel@proxmox.com \
    --to=a.zeidler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal