public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
	"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: [pve-devel] applied: [PATCH common] certificate: actually print openssl errors
Date: Sat, 11 Mar 2023 18:26:34 +0100	[thread overview]
Message-ID: <7aac38ac-81cb-3767-2e50-7152534c9de8@proxmox.com> (raw)
In-Reply-To: <20230307105018.3172827-1-f.gruenbichler@proxmox.com>

Am 07/03/2023 um 11:50 schrieb Fabian Grünbichler:
> print_errs (which is also called internally by die_now) will only 'warn' the
> collected error stack if the log level is set to tracing. otherwise, it will
> just return the error message(s) corresponding to the error stack as string.
> 
> while they are not always the most user-friendly ones, they do provide
> additional context that might help to find out what is actually causing a
> particular failure. both helpers here actually provide a meaninful user
> friendly context (via $msg) as final line.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> 
> Notes:
>     noticed while testing Max' key check series
> 
>  src/PVE/Certificate.pm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
>

applied, with merge conflict resolved as I dropped the unused warn helper
and made the error one a local sub instead of a $code ref in-between, thanks!




      reply	other threads:[~2023-03-11 17:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-07 10:50 [pve-devel] " Fabian Grünbichler
2023-03-11 17:26 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7aac38ac-81cb-3767-2e50-7152534c9de8@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal