public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH qemu-server] net: Skip and warn of interfaces without bridge
@ 2023-04-12  8:45 Christian Ebner
  2023-06-06 16:27 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Christian Ebner @ 2023-04-12  8:45 UTC (permalink / raw)
  To: pve-devel

Handle and warn about network interfaces which are not attached to
any bridge because the user actively removed it from the VM config.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 PVE/QemuServer.pm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index c1d0fd2..3a6c120 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -8574,6 +8574,10 @@ sub add_nets_bridge_fdb {
 	}
 
 	my $bridge = $net->{bridge};
+	if (!$bridge) {
+	    log_warn("Interface '$iface' not attached to any bridge.");
+	    next;
+	}
 	if ($have_sdn) {
 	    PVE::Network::SDN::Zones::add_bridge_fdb($iface, $mac, $bridge, $net->{firewall});
 	} elsif (-d "/sys/class/net/$bridge/bridge") { # avoid fdb management with OVS for now
-- 
2.30.2





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-06-06 16:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-12  8:45 [pve-devel] [PATCH qemu-server] net: Skip and warn of interfaces without bridge Christian Ebner
2023-06-06 16:27 ` [pve-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal