Re: [pve-devel] [PATCH manager 1/2] api: osd: return block devices instead of dm node

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

On 28.03.22 13:10, Aaron Lauterer wrote:
> Returning the block devices is more useful than the device node. The
> device node usually points to the DM device for bluestore OSDs:
> /dev/dm-x
> 
> In almost all situations one will be interested in the physical device
> underneath, /dev/sdX or /dev/nvmeXnY. In the rare case that someone
> isn't, then one can get a lot of more information by running
> `ceph osd metadata <osd nr>`.
> 
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
>  PVE/API2/Ceph/OSD.pm | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/PVE/API2/Ceph/OSD.pm b/PVE/API2/Ceph/OSD.pm
> index 93433b3a..c3d1384e 100644
> --- a/PVE/API2/Ceph/OSD.pm
> +++ b/PVE/API2/Ceph/OSD.pm
> @@ -143,9 +143,9 @@ __PACKAGE__->register_method ({
>  	    if ($e->{type} eq 'osd' && $osdmd) {
>  		if ($osdmd->{bluefs}) {
>  		    $new->{osdtype} = 'bluestore';
> -		    $new->{blfsdev} = $osdmd->{bluestore_bdev_dev_node};
> -		    $new->{dbdev} = $osdmd->{bluefs_db_dev_node};
> -		    $new->{waldev} = $osdmd->{bluefs_wal_dev_node};
> +		    $new->{blfsdev} = $osdmd->{bluestore_bdev_devices};
> +		    $new->{dbdev} = $osdmd->{bluefs_db_devices};
> +		    $new->{waldev} = $osdmd->{bluefs_wal_devices};
>  		} else {
>  		    $new->{osdtype} = 'filestore';
>  		}

oh, and note that this was previously a full device path that could be used by tools
interfacing with the API to open the backing device directly, but now this cannot be
done anymore, and while I would see a change to another full path view of the backing
device (/dev/sdX or /dev/disk/by-XYZ/...) as breaking change, dropping the path
characteristics is almost a bit too much for my liking...